feat(pool): per-request --user/--workdir/--env for pool run#23
Merged
Conversation
pool run gains -u/--user, -w/--workdir, -e/--env (repeatable KEY=VALUE), carried on the wire (serde-default, back-compat) and honored in BOTH modes: deferred (via the spawn-main spec, same user-resolution/seccomp path as a boot main) and exec (via a full ExecRequest instead of the bare exec_command).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pool rungains-u/--user,-w/--workdir,-e/--env(repeatable KEY=VALUE), carried on the wire (serde-default, back-compat with older clients) and honored in both modes:pool start --deferred): via the spawn-main spec — same user-resolution + seccomp path as a boot main;ExecRequest(was the bareexec_command).KVM-verified in both modes:
pool run -u 1000 -w /tmp -e FOO=bar -- sh -c 'echo uid=$(id -u) pwd=$(pwd) FOO=$FOO'→uid=1000 pwd=/tmp FOO=bar, exit 0. 16 pool unit tests pass (roundtrip + spec-builder updated for the new fields).