Add option to enable on-demand profiling server in MaxText ML Diagnostics#4131
Open
copybara-service[bot] wants to merge 1 commit into
Open
Add option to enable on-demand profiling server in MaxText ML Diagnostics#4131copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
requested review from
A9isha,
NicoGrande,
NuojCheng,
RissyRan,
SurbhiJainUSC,
abhinavclemson,
aireenmei,
bvandermoon,
darisoy,
dipannita08,
gagika,
gobbleturk,
hengtaoguo,
igorts-git,
jesselu-google,
jiangjy1982,
khatwanimohit,
richjames0,
shralex,
suexu1025 and
vipannalla
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
copybara-service
Bot
force-pushed
the
test_929618169
branch
from
cb11a92 to
f73154f
Compare
…tics - Add `managed_mldiagnostics_on_demand_profiling` configuration flag to `base.yml` (enabled by default) and `types.py`. - Pass `on_demand_xprof` parameter to `mldiag.machinelearning_run(...)` in `managed_mldiagnostics.py` to allow users to toggle on-demand profiling at runtime. Fixes #4129. PiperOrigin-RevId: 929618169
copybara-service
Bot
force-pushed
the
test_929618169
branch
from
f73154f to
a8d5c4a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add option to enable on-demand profiling server in MaxText ML Diagnostics
managed_mldiagnostics_on_demand_profilingconfiguration flag tobase.yml(enabled by default) andtypes.py.on_demand_xprofparameter tomldiag.machinelearning_run(...)inmanaged_mldiagnostics.pyto allow users to toggle on-demand profiling at runtime.Fixes #4129.