Fix transformer issues - #572
Open
jchung01 wants to merge 4 commits into
Open
Conversation
- Also moves PickBlock hook out of visitor to avoid loading MC classes
This was referenced Jul 4, 2025
- Improves mod compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PacketUtil#writeItemStackFromClientToServer().ItemStack,PacketBufferandPacketUtiltoClassVisitors.Previously, recieved
CPacketClickWindowpackets had invalidItemStacks sent by the client because the itemstack in the packet is sent usingPacketUtil, which is not patched, while the itemstack is read usingPacketBuffer#readItemStack(). This meant stack sizes past the vanilla amount were not being received correctly. Somehow, this did not cause visible issues in AE2 guis when interacting with oversized slots. However, it can cause network errors and kick the player on dedicated servers when ModularUI is present due to it also patching stack sizes and making assumptions on how to exclude its patches when AE2 is present.See CleanroomMC/ModularUI#154 for more details. This PR makes the necessary changes on AE2's side to fix the error. Once this is merged, necessary changes should be made on MUI's side to fix the error.