Fix for Issue #250: Dashboard does not reflect changes to node over time#356
Open
AileenCleary wants to merge 2 commits into
Open
Fix for Issue #250: Dashboard does not reflect changes to node over time#356AileenCleary wants to merge 2 commits into
AileenCleary wants to merge 2 commits into
Conversation
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Info
Fix for Issue #250.
Dashboard
NodeModalwas slow to update changes in node information or actions. Page was stale and needed to be manually refreshed or opened and closed, and the refresh time default was 01:00 minutes.Changes
1. Reduce node_info_update_interval default from 60.0 to 30.0.
By decreasing the default value of node_info_update_interval, the workcell will more frequently query node information, therefore detecting any changes made and updating the dashboard.
2. Fix the UI by having NodeModal use computed property over modal_text.
Currently,
NodeModalusesprops.modal_textto feed intoNodeInfoTabandNodeActionsTab, which is a snapshot that is only captured once when the modal is opened. Thus, even ifwc_stateupdates later with new node information,modal_textwill not change. Instead, we now use a computed propertycurrent_node_infothat reads directly fromwc_state.nodes[modal_title].info. Becausewc_stateis reactive,current_node_infowill automatically update when the workcell manager pushes new node information into the workcell state.Developer Checklists
I have: