Skip to content

Feature error handling MVP#312

Open
tginsbu1 wants to merge 7 commits into
unstablefrom
295-feature-error-handling-mvp
Open

Feature error handling MVP#312
tginsbu1 wants to merge 7 commits into
unstablefrom
295-feature-error-handling-mvp

Conversation

@tginsbu1

@tginsbu1 tginsbu1 commented May 5, 2026

Copy link
Copy Markdown
Contributor

PR Info

Adds an Error handler that handles error events and pauses active workflows, with swappable error handler similar to Scheduler

Developer Checklists

I have:

  • Run Pre-commit and Unit Tests, and ensured that they pass
  • Created or updated documentation relevant to your change
  • Created or updated unit tests relevant to your change

@tginsbu1
tginsbu1 requested a review from RyanTheRobothead May 5, 2026 17:31
Comment thread src/madsci_client/madsci/client/workcell_client.py Outdated
self.event_handlers = []
for handler_name in settings.event_handlers:
handler_module = importlib.import_module(handler_name)
handler = handler_module.EventHandler(self.settings)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work unless every handler module has a class named EventHandler defined in it

Comment thread src/madsci_common/madsci/common/types/event_types.py Outdated
tginsbu1 and others added 3 commits May 19, 2026 11:57
Co-authored-by: Ryan D. Lewis <ryan.lewis@anl.gov>
…efault_error_handler.py

Co-authored-by: Ryan D. Lewis <ryan.lewis@anl.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants