fix(ci): dist:win 加 --publish never 避免 403 cleanup 错误 - #117
Merged
Conversation
CI build.yml 跑 'bun run dist:win',但该脚本没有 --publish 参数。 electron-builder 检测到 electron-builder.yml 里的 publish: github 配置后,在 build 结束的 cleanup 阶段尝试访问 GitHub Release API, build workflow 的 token 无 release 写权限 → 403 Forbidden → build 失败。 v0.3.0 发布后 release 里有了 latest.yml,electron-builder 的 cleanup 逻辑开始访问它,暴露了这个一直存在的问题(之前 release 为空时 cleanup 是 no-op)。 修复: dist:win 加 --publish never(与 pack 一致)。发布仍走 dist:win:publish (--publish always),不受影响。
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the 'dist:win' script in 'package.json' to append the '--publish never' flag, preventing automatic publishing during Windows distribution builds. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题
master 上 PR #116 (bump v0.3.0) 的 Build CI 失败:
HttpError: 403 Forbidden在 electron-builder 的 cleanup 阶段。根因
CI build.yml 跑
bun run dist:win,但该脚本缺少--publish参数。electron-builder 检测到electron-builder.yml的publish: github配置后,在 build 结束的 cleanup 阶段尝试访问 GitHub Release API。build workflow 的 token 无 release 写权限 → 403。v0.3.0 发布后 release 里有了
latest.yml,electron-builder 的 cleanup 开始访问它,暴露了这个一直存在的问题(此前 release 为空,cleanup 是 no-op,所以 PR #115 能过)。修复
dist:win加--publish never(与pack一致)。正式发布仍走dist:win:publish(--publish always),不受影响。