Skip to content

Confusing! There are many variables with similar names, inconsistently named. #44

Closed

Description

@A-Infor

Pay attention:

  1. dataTrueValues_dict and monthsForPredicted_dict don't have a consistent naming, despite having the same role;
  2. dataForPrediction_dict and monthsForPrediction_dict have a consistent naming, and have the same role.

Then, predictValues_dict is created, inside NeuralNetwork.use_neural_network(). These are tha values that indeed have been predicted.

All these names are really confusing!

Activity

  1. self-assigned this
    on Jul 11, 2025
  2. A-Infor commented on Jul 11, 2025

    @A-Infor
    OwnerAuthor

    I think that the variables could be renamed like this:

    1. dataTrueValues_dict → spei_provided_inputs
    2. monthsForPredicted_dict → months_for_provided_inputs
    3. dataForPrediction_dict → spei_expected_outputs
    4. monthsForPrediction_dict → months_for_expected_outputs
    5. predictValues_dict → spei_predicted_values
  3. added a commit that references this issue on Jul 24, 2025
    e82ced4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions