Skip to content

Remove duplicate push logging and preserve structured request results#2

Merged
tompesman merged 2 commits into
developfrom
codex/fix-duplicate-push-logging
Jul 14, 2026
Merged

Remove duplicate push logging and preserve structured request results#2
tompesman merged 2 commits into
developfrom
codex/fix-duplicate-push-logging

Conversation

@tompesman

Copy link
Copy Markdown
Member

Summary

  • Stop logging failed push events twice by letting Rocket.Request own request/error logging.
  • Encode payloads before posting so request errors stay structured and custom response handlers still receive the original payload.
  • Add coverage for configuration, encoding, exit, and HTTP error paths, including custom call/3 handlers.
  • Bump locked HTTP dependency versions in mix.lock.

Testing

  • Added and updated unit tests around Rocket.Request.perform/2 and Rocket.Pusher.handle_events/3.
  • Verified error logging happens once per failure path and that custom response handlers are invoked exactly once.
  • Not run (not requested).

@tompesman tompesman merged commit 93c0fe5 into develop Jul 14, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant