Skip to content

fix: fix license classifier#7

Open
joostlek wants to merge 2 commits into
930913:mainfrom
joostlek:patch-1
Open

fix: fix license classifier#7
joostlek wants to merge 2 commits into
930913:mainfrom
joostlek:patch-1

Conversation

@joostlek

Copy link
Copy Markdown

Hey 👋🏻,

I am currently looking into licensing at Home Assistant, and I found that we could not detect the license of this library properly. According to pyproject.toml documentation about the license field:

If you are using a standard, well-known license, it is not necessary to use this field. Instead, you should use one of the classifiers starting with License ::. (As a general rule, it is a good idea to use a standard, well-known license, both to avoid confusion and because some organizations avoid software whose license is unapproved.)

If you could do a release after this PR, and maybe bump in Home Assistant, that would be awesome :)

Comment thread pyproject.toml Outdated
"Natural Language :: English",
"Operating System :: OS Independent",
"Topic :: Software Development :: Libraries",
"License :: OSI Approved :: Apache Software License",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"License :: OSI Approved :: Apache Software License",

If you change the license string above to Apache-2.0, the classifier is added by poetry. Wasn't able to leave a suggestion for some reason.
https://python-poetry.org/docs/pyproject/#license

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants