Skip to content

Complete onboarding exercises 1-5 - #5

Merged
dvorakjt merged 1 commit into
8by8-org:developmentfrom
Nickhegde:onboard-nickhegde
Jul 30, 2026
Merged

Complete onboarding exercises 1-5#5
dvorakjt merged 1 commit into
8by8-org:developmentfrom
Nickhegde:onboard-nickhegde

Conversation

@Nickhegde

@Nickhegde Nickhegde commented Jul 26, 2026

Copy link
Copy Markdown
Member

Checklist

Please ensure you have followed all of the steps below before submitting a pull request:

  • Test your code (npm test or npm run test)
  • Check your types (npm run typecheck)
  • Lint your code (npm run lint)
  • Format your code (npm run format)
  • Document your code with TSDoc comments

Overview

Completes onboarding exercises 1–5:

  • 01 - Algorithms and Testing: Implemented rotateArray, which rotates an array to the right by a given number of steps, correctly handling steps larger than the array length and negative steps. Replaced the test scaffold's it.todo placeholders with real assertions covering rotation, wraparound, negative steps, non-mutation, and empty-array input.
  • 02 - Writing TSDoc Comments: Replaced placeholder TSDoc on formatFullName with a full description, parameter docs, and return value docs.
  • 03 - Fixing Type Errors: Fixed the type error in scores (a string literal "6" where ScoreEntry.score expects a number) without changing getHighestScore's behaviour.
  • 04 - Fixing Linting Issues: Removed the unused ignoredValue and replaced the unsafe any type on record with a concrete { name: string } type in formatReviewer.
  • 05 - Fixing Formatting: Ran npm run format; the file was already Prettier-compliant, confirmed via an empty diff after running the command.

Test Plan

  • Ran npm run test - all tests pass, including the 5 tests added for rotateArray (rotation, wraparound past array length, negative steps, non-mutation, empty array).
  • Ran npm run typecheck - no type errors.
  • Ran npm run lint - no lint errors.
  • Ran npm run format - confirmed via git diff that no formatting changes were needed on the exercise 5 file.

@Nickhegde
Nickhegde marked this pull request as draft July 26, 2026 18:23
@Nickhegde
Nickhegde marked this pull request as ready for review July 26, 2026 18:25
@Nickhegde Nickhegde assigned dvorakjt and unassigned dvorakjt Jul 28, 2026
@Nickhegde
Nickhegde requested a review from dvorakjt July 28, 2026 14:43

@dvorakjt dvorakjt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Well done!

@dvorakjt
dvorakjt merged commit 82ddea2 into 8by8-org:development Jul 30, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants