Skip to content

finish onboarding exercises - #2

Merged
dvorakjt merged 1 commit into
8by8-org:developmentfrom
Shawnhec:onboard-Shawnhec
Jun 13, 2026
Merged

finish onboarding exercises#2
dvorakjt merged 1 commit into
8by8-org:developmentfrom
Shawnhec:onboard-Shawnhec

Conversation

@Shawnhec

@Shawnhec Shawnhec commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Checklist

Please ensure you have followed all of the steps below before submitting a pull request:

  • Test your code (npm test or npm run test)
  • Check your types (npm run typecheck)
  • Lint your code (npm run lint)
  • Format your code (npm run format)
  • Document your code with TSDoc comments

Overview

This PR completes the onboarding exercises.

Key changes:

  • Implemented required algorithm in exercise 01.
  • Wrote TSDoc description for the function in exercise 02.
  • Fixed the TypeScript errors in the file without changing the intended behavior in exercise 03.
  • Resolved the linting issues in exercise 04.
  • Reformatted file of exercise 05.

Test Plan

I verified all components locally within the terminal before pushing:

  1. npm run typecheck - 0 errors found.
  2. npm run lint & npm run format - 0 issues found and and files formatted.
  3. npm run test - All mock tests of exercise 01 passed.

@Shawnhec
Shawnhec requested a review from dvorakjt June 7, 2026 17:08
@dvorakjt
dvorakjt requested a review from CaptainExtremis June 7, 2026 19:24

@CaptainExtremis CaptainExtremis left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All checks pass, code looks clean. Well done, Shawn!

@dvorakjt dvorakjt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@dvorakjt
dvorakjt merged commit bbf49a0 into 8by8-org:development Jun 13, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants