Skip to content

Harden KAG export artifact admission#493

Merged
8Dionysus merged 1 commit into
mainfrom
codex/reconcile-review-fixes-20260713
Jul 13, 2026
Merged

Harden KAG export artifact admission#493
8Dionysus merged 1 commit into
mainfrom
codex/reconcile-review-fixes-20260713

Conversation

@8Dionysus

Copy link
Copy Markdown
Owner

What changed

  • sanitize imported abyss-machine roots before public KAG-export bundle signing and gating
  • require explicit consumer verdict and fail-closed admission evidence
  • add downstream contract regressions
  • regenerate the canonical repo-local KAG index family

Why

The KAG export validator could retain host-specific verifier paths and did not fully constrain the consumer admission response. The updated boundary is portable and explicit.

Validation

  • python scripts/ci_gate.py --mode source-fast
  • python scripts/release_check.py including part-local and mechanics suites
  • focused downstream tests: 12 passed, 13 subtests
  • pinned repo-local KAG full, incremental, and family validation

@8Dionysus
8Dionysus marked this pull request as ready for review July 13, 2026 23:33
@8Dionysus
8Dionysus merged commit e45b41f into main Jul 13, 2026
1 check passed
@8Dionysus
8Dionysus deleted the codex/reconcile-review-fixes-20260713 branch July 13, 2026 23:33

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d65d0f2bc1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +99 to +103
for raw in (
os.environ.get("ABYSS_MACHINE_REPO_ROOT"),
os.environ.get("ABYSS_MACHINE_PACKAGE_ROOT"),
"/srv/AbyssOS/abyss-machine",
):

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Sanitize the same abyss-machine roots the importer uses

When abyss-machine is discovered through the built-in adjacent or home checkout fallbacks in _candidate_abyss_machine_roots() (for example /workspace/abyss-machine or ~/src/abyss-machine), _import_artifact_bundles() passes that root into the verifier, but this new sanitizer only redacts env-provided roots and /srv/AbyssOS/abyss-machine. If the generated sidecars or registry payloads contain the selected abyss_repo_root, those common fallback layouts are left unsanitized and the later public-leak assertion against abyss_machine_root still rejects the bundle instead of producing the portable redaction this change is meant to guarantee.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant