Skip to content

fix: correct SC citation, copyright years, and harden validator and build script - #3

Merged
84em merged 1 commit into
mainfrom
fix/review-findings
Jul 11, 2026
Merged

fix: correct SC citation, copyright years, and harden validator and build script#3
84em merged 1 commit into
mainfrom
fix/review-findings

Conversation

@84em

@84em 84em commented Jul 11, 2026

Copy link
Copy Markdown
Member

Fixes the five findings from an adversarial review and fact check of the repository.

Changes

  • SKILL.md common-mistakes table: the placeholder-as-label row cited 1.3.5 Identify Input Purpose, which governs the autocomplete attribute and is unrelated to labeling. Now cites 3.3.2 Labels or Instructions with a tighter rationale (placeholder vanishes on input).
  • SKILL.md frontmatter: description now says six A/AA criteria new in WCAG 2.2. Nine criteria are new in 2.2 overall; three are AAA and out of scope for this skill.
  • scripts/validate.mjs: the emdash check covered only SKILL.md while AGENTS.md rule 5 names four authored files. Now checks SKILL.md, README.md, AGENTS.md, and CHANGELOG.md. Negative-tested: an injected emdash in README.md fails validation with the expected message.
  • scripts/build-reference.sh: curl now uses --fail (-sSfL) so an upstream 404/500 aborts the script instead of converting the error page and clobbering the committed reference.
  • W3C copyright year corrected from 2024 to 2020-2024 in NOTICE, the build script header heredoc, and the committed reference attribution comment, matching the copyright line in the spec itself. The heredoc and the committed header were diffed after the edit and are byte-identical, so the CI drift check stays quiet.

CHANGELOG updated under Unreleased.

Verification

  • node scripts/validate.mjs passes (A=31 AA=24 AAA=31 total=86)
  • markdownlint-cli 0.45.0 clean with the CI invocation
  • bash -n on the build script passes; shellcheck runs in CI (not installed locally)

…uild script

- SKILL.md: placeholder-as-label mistake row cited 1.3.5 Identify Input
  Purpose, which governs autocomplete; now cites 3.3.2 Labels or
  Instructions
- SKILL.md: frontmatter description qualifies the six new criteria as
  A/AA (2.2 adds nine overall, three of them AAA)
- validate.mjs: emdash check now covers all four authored docs, matching
  AGENTS.md rule 5 (was SKILL.md only)
- build-reference.sh: curl now fails on HTTP errors instead of writing
  an upstream error page over the committed reference
- NOTICE, reference attribution header, and build script header: W3C
  copyright year corrected to 2020-2024 to match the spec's own line
@84em
84em merged commit 135e75c into main Jul 11, 2026
2 checks passed
@84em
84em deleted the fix/review-findings branch July 11, 2026 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant