Add a custom filter option#3
Open
sandypreiss wants to merge 3 commits into
Open
Conversation
Enables filtering on tracks/mixes and play count together. - Track/mix filter is implemented as a toggle with a fixed 30 min track length threshold - Play count filter is flexible with integer user input and operator toggle
- Increment version number from 1.0.7 to 1.1.0 - Add data_collection_permissions (now required for firefox)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The custom filter enables filtering for tracks/mixes and filtering for play count together.
The tracks/mixes filter is implemented as a toggle using the 30 min threshold from
filters/onlySingles.js.The play count filter is implemented as a user input with an operator toggle.
This requires reading filter parameters from
browser.storage.syncincontent.jsand injecting them as a page-context global whichfilters/custom.jsreads. This follows the pattern used forauxData.I wrote this as a personal project, because I most often scroll Soundcloud looking for mixes with at least a few dozen plays. It works well as a temporary firefox add-on. I thought about uploading it to Mozilla as a separate add-on, but thought I'd see if you want to incorporate the addition to your existing add-on first.