chore: post-2.2.0 cleanup batch#72
Merged
Merged
Conversation
…racy Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Post-2.2.0 cleanup batch — four small, independent code edits. No release, no version bump, no consumer-visible behavior change. Ships with the next feature release.
Changes
servers/server.go—Fatalfformat-string vet fixes (%w→%von L139; verb-less%vadded on L183, L191).middleware/cache.go— tighten tickets cache-bypass from looseHasPrefixto exact path OR trailing-slash prefix. Defense-in-depth; no existing route changes behavior.servers/server.go—setupRedisno longer exits on emptyREDIS_PASSWORD; logs an info line and connects without AUTH. Prod is unaffected (password is set in compose env); enables local-dev against a vanillaredis:7.cmd/serve.go,servers/server.go— document thatPORTis the gateway-to-grpc dial target, not a listen port. Both listen ports are hardcoded. (CLAUDE.mdgot a matching paragraph update on disk for local-Claude context; that file is.gitignored in this repo so it does not appear in this diff.)Commits
Five commits — four tasks plus one fix-up on the PORT doc commit to drop a misleading "loopback" word and rewrite the
Newdoc-comment to drop the inaccurate "not a listen address" framing. Squash-merge.Verification
go vet ./...is clean (the three pre-existing warnings onservers/server.goL139/183/191 are gone).go build ./...exits 0.xenforo-dbmirror (v2.2.0 schema present): binary starts with emptyREDIS_PASSWORDand logs the newREDIS_PASSWORD empty — connecting without AUTHinfo line (Task 3 verified end-to-end); both:10000and:11000bind; OpenAPI UI returns 200;/api/v1/milpac/1and/api/v1/tickets[/123]return 401 against the gateway, proving the gateway-to-gRPC dial path works underPORT=10000(Task 4 invariant verified).make generateneeded.monitoredTableschange needed.Closes #70