Bump gorm.io/driver/mysql from 1.5.7 to 1.6.0#60
Closed
dependabot[bot] wants to merge 1 commit into
Closed
Conversation
dependabot
Bot
added
dependencies
dependabot
Bot
force-pushed
the
dependabot/go_modules/gorm.io/driver/mysql-1.6.0
branch
from
May 19, 2026 02:02
f71c09d to
1fb5e4b
Compare
Bumps [gorm.io/driver/mysql](https://github.com/go-gorm/mysql) from 1.5.7 to 1.6.0. - [Commits](go-gorm/mysql@v1.5.7...v1.6.0) --- updated-dependencies: - dependency-name: gorm.io/driver/mysql dependency-version: 1.6.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
force-pushed
the
dependabot/go_modules/gorm.io/driver/mysql-1.6.0
branch
from
May 19, 2026 23:58
1fb5e4b to
15010e1
Compare
5 tasks
SyniRon
added a commit
that referenced
this pull request
May 20, 2026
Bumps:
- gorm.io/driver/mysql v1.5.7 → v1.6.0
- gorm.io/gorm v1.25.12 → v1.30.0 (transitive via the driver bump)
Code fix needed for the bump:
FindProfileByKeycloakID and FindProfileByDiscordID built their WHERE
clauses with a map[string]interface{} keyed on
"xf_user_connected_account.provider" / ".provider_key". gorm 1.25
forwarded such dotted keys verbatim. gorm 1.26+ (so 1.30 here)
treats the entire map key as a column name and prefixes it with
the current model's table, producing nonsense like
`xf_nf_rosters_user`.`xf_user_connected_account`.`provider`
in the rendered SQL — a three-part qualifier MariaDB rejects with
"Unknown column ... in 'where clause'".
Effect on develop: discord/keycloak ID lookups returned 404
("no user found") for every input. Insomnia suite went 61/61 → 49/61.
Fix: replace the dotted-key map with raw placeholder SQL on both
functions so the joined-table column names stay unqualified through
gorm's escape pass.
Smoked locally against a fresh XF DB mirror — both lookups return
200 with the expected profile, and the canonical-jq diff of the
other 11 baseline endpoints (ranks / position-groups / awol /
profile by id+username / full + lite rosters / s1 uniforms /
tickets categories+list+single) shows byte-for-byte identical
JSON content vs the pre-bump develop responses.
Supersedes #60.
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Collaborator
|
Closing ref #75 |
Contributor
Author
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
dependabot
Bot
deleted the
dependabot/go_modules/gorm.io/driver/mysql-1.6.0
branch
May 20, 2026 00:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebasing might not happen immediately, so don't worry if this takes some time.
Note: if you make any changes to this PR yourself, they will take precedence over the rebase.
Bumps gorm.io/driver/mysql from 1.5.7 to 1.6.0.
Commits
d744156Don't overwrite existing clause buildersf0a2645build(deps): bump gorm.io/gorm from 1.25.11 to 1.30.0 (#172)d815729Fix creating unique index on non-unique field (#168)449c37aUpdated the go version to 1.18. (#159)