openapi: document position-search empty-result semantics (#137 ruled expected)#168
Merged
Merged
Conversation
…expected) Diagnosis on the mirror confirmed the matcher is a correct case-insensitive unanchored substring LIKE (squad leader: 0 rows; section leader: 125; SECTION LEADER: 125; platoon leader: 22 — through the exact join+filter shape). Empty results are data-truthful: the org's billet vocabulary has Section/Platoon Leaders, no "Squad Leader" title. Closes #137 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves the #137 verdict question: expected behavior, not a bug. The spec description for
MilpacService_SearchByPositionnow states case-insensitivity and what an empty profiles map means.Diagnosis (mirror DB, exact query shape — join + secondary filter)
squad leadersection leaderSECTION LEADERplatoon leaderThe matcher (escaped substring
LIKE, case-insensitive via collation) is correct. The org's billet vocabulary has Section Leader / Assistant Section Leader / Platoon Leader (357 rows); the only "Squad"-titled positions are staff roles.{"profiles":{}}for "squad leader" is data-truthful.No behavior change — prose-only spec edit;
go test -count=1 ./openapi/... ./contract/...green.Closes #137
🤖 Generated with Claude Code