Add video-to-frame image sequence export - #142
Draft
blackridder22 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI-generated code disclosure
Summary
Adds an opt-in image-sequence mode for video sources. A user can select JPEG, WebP, PNG, BMP, or TIFF, choose Image sequence, and export every decoded video frame into a uniquely named folder.
What changed
single/sequenceimage-output modes with legacy defaults;frame_%06doutput for sequences;-frames:v 1 -update 1behavior;<name>_frames,<name>_frames_2, and subsequent collision-safe folders;settings-image-sequencevisual fixture and focused tests.User impact
A video can now be converted into all of its decoded frames without manually invoking FFmpeg. For example, a 30-second, 30-fps video displays an estimate of approximately 900 frames. Variable-frame-rate sources use their actual decoded timing, so the final count may differ from the estimate.
Validation performed
cargo fmt --all -- --checkcargo test --locked -p frame-core— 117 passedcargo test --locked -p frame-app --features gpui_platform/runtime_shaders --lib— 744 passedcargo clippy --all-targets --features gpui_platform/runtime_shaders -- -D warningscargo xtask workflows --checksettings-image-sequencefixture.appwith bundled FFmpeg 8.1.2Local toolchain limitation
cargo xtask cicompletes the core checks but the standard GPUI app build stops on this machine because only Apple Command Line Tools are installed andxcruncannot find themetalcompiler. The app test suite and clippy pass with GPUI runtime shaders. This should still be rerun by CI or a maintainer machine with full Xcode installed.