50. Pow(x, n)#45
Open
5ky7 wants to merge 1 commit into
Open
Conversation
nodchip
reviewed
Apr 12, 2026
| class Solution { | ||
| public: | ||
| double myPow(double x, long long n) { | ||
| if (n == 0) return 1.0; |
There was a problem hiding this comment.
ぶら下がり if 文はバグの原因になる場合があるため、避けたほうが無難だと思います。
|
|
||
| if (n > 0) { | ||
| if (n % 2 == 0) { | ||
| double sqrt = myPow(x, n / 2); |
Owner
Author
There was a problem hiding this comment.
既存関数との名前衝突ですね．気をつけます．
しかも関数と変数の名前衝突なので余計ややこしいことになりそうです...
| return 1.0; | ||
| } | ||
| if (n < 0) { | ||
| if (n == std::numeric_limits<int>::min()) { |
There was a problem hiding this comment.
特定の値だけ特別処理をしているのが、やや煩わしく感じました。自分なら int64_t を引数に取るヘルパー関数を定義し、そちらに渡すようにすると思います。
Owner
Author
There was a problem hiding this comment.
定義域を拡張したhelper関数を用意した方がすっきりしますね．
ありがとうございます．
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
50. Pow(x, n)