feat: Respect author replies to dismiss reasonable justifications - #24
Merged
Conversation
- Add stable finding IDs generated from file/line/description. - Embed invisible finding ID marker in every inline comment. - Add review-replies module to fetch replies and evaluate justifications via LLM. - Integrate reply evaluation as optional pipeline stage controlled by respect-author-replies input. - Add respect-author-replies input to action.yml and README. - Update tests and build dist bundle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces the ability for the bot to read and understand replies to its own review comments. If an author replies to a finding with a reasonable justification explaining why the change is not applicable, the bot will dismiss that finding and stop re-requesting it in subsequent review rounds.
This prevents review loops where the bot repeatedly requests changes for something the author has already explained is not needed.
Key Changes
ReviewFindingnow has a stableidgenerated from the file, line, and normalized description. This ID is used to track findings across review rounds.<!-- livvie:finding-id:abc123 -->) in every inline review comment. This marker is used to correlate replies back to the original finding.review-replies.ts: This module handles the new logic:fetchAuthorReplies: Fetches review comments and identifies replies from human authors to the bot's comments.evaluateAuthorReplies: Uses the configured LLM to evaluate the reasonableness of each author reply.filterDismissedFindings: Removes findings from the review that have been justified by the author.respect-author-repliesInput: A new opt-in boolean inputrespect-author-replieshas been added toaction.ymlto enable this feature (defaults tofalse).README.mdhas been updated with documentation for the new feature, including a new section explaining how it works.How to Use
To enable this feature, add the following to your workflow file: