feat: approve PR when no finding matches request-changes-on - #23
Merged
Merged
Conversation
…ges-on When findings exist but none match the severities configured in request-changes-on, the review event is now APPROVE instead of COMMENT. This makes the behavior binary: the PR either gets blocked (REQUEST_CHANGES) or approved; non-blocking findings are still visible as inline comments. - Update postReview event logic. - Update post.test.ts expectations. - Update README architecture section. - Rebuild dist/index.js.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
When findings exist but none match the severities configured in
request-changes-on, the review event is nowAPPROVEinstead ofCOMMENT.Why
This makes the action behavior binary and predictable: a PR either gets blocked (
REQUEST_CHANGES) or is approved. Non-blocking findings are still visible as inline comments, but they no longer leave the PR in an intermediate "commented" state.Changes
src/post.ts: simplified event logic toREQUEST_CHANGESorAPPROVE.src/post.test.ts: updated test expectations.README.md: updated behavior description.dist/index.js: rebuilt.How to test
With a
lowfinding, the review will beAPPROVE(with the inline comment still posted).Checklist
npx tsc --noEmitnpm run lintnpx vitest run(281 tests)npm run build