fix(security): SEC-619 raise minimum deployment target to iOS 17#54
Open
juwoncube wants to merge 1 commit into
Open
fix(security): SEC-619 raise minimum deployment target to iOS 17#54juwoncube wants to merge 1 commit into
juwoncube wants to merge 1 commit into
Conversation
…ersion to 3.3.2 SEC-619: pen test flagged EOL minimum OS deployment targets in embedded frameworks. Raises IPHONEOS_DEPLOYMENT_TARGET from 15.0/16.0 to 17.0 and bumps MARKETING_VERSION to 3.3.2.
juwoncube
requested review from
3scsamdavis,
JonValijonov,
Szuyun-3SC and
neil3sidedcube
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Pen test finding (SEC-619): embedded frameworks of the Blood iOS app declare end-of-life minimum OS deployment targets. ThunderRequest is one of 8 3SC frameworks being updated.
What changed
IPHONEOS_DEPLOYMENT_TARGETraised to 17.0 inproject.pbxproj(was 15.0 at project level, 16.0 on the iOS framework/test targets)MARKETING_VERSIONbumped 3.3.0 → 3.3.2Build & test results
xcodebuildThunderRequest-iOS, generic/platform=iOS: BUILD SUCCEEDED, no warningsDownloadTests/testDownloadSavesToDisk— crash (signal trap)RequestBodyTests/testCodableBodyCreatesDataCorrectly+ 4MultipartFormTests— byte-count assertions sensitive to OS encoder outputNew deprecation warnings
None introduced by the bump.
Adoption note
Consumer apps must target iOS >= 17.0 to adopt this version.