TTS-2142 Fix method grouping - #29
Merged
andriipokrovskyi merged 4 commits intoJun 16, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes method-grouping behavior in Obfuscar’s inheritance map so that related/overriding methods are more reliably merged into a single group, preventing inconsistent renames across a hierarchy.
Changes:
- Removes the post-pass “merge overlapping method groups” step in
InheritMapand instead builds/merges method groups incrementally while scanning nodes. - Updates
GraphNode.FillMethodGroupto operate on a sharedIDictionary<MethodKey, MethodGroup>and merge groups on contact (including re-pointing keys when merging). - Minor refactors in
GraphNode(spelling fixscaned→scanned,readonlyfields, visibility tweak tointernal).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Obfuscar/InheritMap.cs | Switches method grouping to rely on GraphNode.FillMethodGroup writing directly into methodGroups, eliminating the separate merge pass. |
| Obfuscar/GraphNode.cs | Reworks method grouping to use a shared dictionary and perform merging during traversal; includes small refactors/cleanup. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mv3shape
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Old method grouping strategy created a lot of unnecessary groups and failed to merge them properly, resulting in related methods having different names.