Skip to content

fix(indexer): make managed config readable by module host - #418

Merged
3esmit merged 1 commit into
mainfrom
3esmit/fix-indexer-config-permissions
Sep 19, 2026
Merged

3esmit merged 1 commit into
mainfrom
3esmit/fix-indexer-config-permissions

Conversation

@3esmit

@3esmit 3esmit commented Sep 19, 2026

Copy link
Copy Markdown
Owner

Summary

  • make managed Channel Indexer configuration readable by the LogosCore module host after atomic replacement
  • normalize permissions for existing valid configurations
  • apply the same permission contract to direct managed Indexer start writes
  • add Unix regression coverage for atomic and direct writers

Fixes #417
Related: 3esmit/logos-execution-zone#65, 3esmit/lez-indexer-module#1

Validation

  • cargo fmt --all -- --check
  • python3 scripts/check-build-pipeline.py ci
  • focused Channel Indexer and action-workspace tests
  • full Rust, native CTest, UI, headless CLI, and QML checks passed.

Copilot AI lite review requested due to automatic review settings September 19, 2026 06:30

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 19, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-19T06:37:12.291850Z 6bb3e28 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 19e9b5a881

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

validate_indexer_config_value(&value, context).context(
"Channel Indexer configuration is invalid; open Zone Sources and repair it before starting",
)?;
make_indexer_config_readable(&path)?;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Normalize permissions before resetting storage

When upgrading with an existing 0600 configuration and selecting Reset data before Start, this normalization never runs: basecamp_purge_indexer uses persisted_basecamp_indexer_config and passes that path directly to the module host's reset_storage call. Inspector can validate the owner-readable file, but the separate module host still cannot read it, so reset fails with the same permission problem this change fixes for Start. Apply the readability normalization in the purge path as well.

Useful? React with 👍 / 👎.

@3esmit
3esmit force-pushed the 3esmit/fix-indexer-config-permissions branch from 19e9b5a to 6bb3e28 Compare September 19, 2026 06:34
@3esmit
3esmit merged commit 6f494c0 into main Sep 19, 2026
9 checks passed
@3esmit
3esmit deleted the 3esmit/fix-indexer-config-permissions branch September 19, 2026 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make managed Indexer configuration readable by LogosCore host

2 participants