Repository navigation
fix(indexer): make managed config readable by module host - #418
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 19e9b5a881
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| validate_indexer_config_value(&value, context).context( | ||
| "Channel Indexer configuration is invalid; open Zone Sources and repair it before starting", | ||
| )?; | ||
| make_indexer_config_readable(&path)?; |
There was a problem hiding this comment.
Normalize permissions before resetting storage
When upgrading with an existing 0600 configuration and selecting Reset data before Start, this normalization never runs: basecamp_purge_indexer uses persisted_basecamp_indexer_config and passes that path directly to the module host's reset_storage call. Inspector can validate the owner-readable file, but the separate module host still cannot read it, so reset fails with the same permission problem this change fixes for Start. Apply the readability normalization in the purge path as well.
Useful? React with 👍 / 👎.
19e9b5a to
6bb3e28
Compare
Summary
Fixes #417
Related: 3esmit/logos-execution-zone#65, 3esmit/lez-indexer-module#1
Validation
cargo fmt --all -- --checkpython3 scripts/check-build-pipeline.py ci