Skip to content

fix(deps): align inspector with merged module builder - #416

Merged
3esmit merged 1 commit into
mainfrom
3esmit/deps/runtime-pin-20260918
Sep 18, 2026
Merged

3esmit merged 1 commit into
mainfrom
3esmit/deps/runtime-pin-20260918

Conversation

@3esmit

@3esmit 3esmit commented Sep 18, 2026

Copy link
Copy Markdown
Owner

Closes #373

Summary:

  • pin module-builder and protocol inputs to the merged fork revisions
  • consume the merged storage-module API fix
  • expose the sibling core module output to the QML module builder
  • update release-workflow revision policy and regenerate the lock file

Validation:

  • cargo fmt --all -- --check
  • nix flake check --no-build --accept-flake-config
  • nix build .#packages.x86_64-linux.default --no-link --accept-flake-config -L
  • python3 scripts/check-build-pipeline.py ci (all checks passed, including 1,452 Rust tests, 1,325 QML tests, native CTest, UI checks, Clippy, and headless CLI)

Copilot AI lite review requested due to automatic review settings September 18, 2026 07:19

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 18, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-18T07:28:35.531403Z 1c2f12e New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ddf9bfff72

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/inspection/catalog/worker.rs Outdated
Comment on lines +471 to +473
} else {
no_progress_round = no_progress_round.saturating_add(1);
if should_publish_no_progress_warning(no_progress_round) {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Gate the warning on an outstanding catalog target

When the catalog is fully synchronized and the finalized LIB remains unchanged, made_progress is naturally false even though chain_status() succeeded and the cursor already equals target. After three such healthy polling rounds, this branch publishes an error claiming that Bedrock is unreachable, and the error remains until another catalog commit occurs. Track whether the cursor is actually behind the target (or whether a range request unexpectedly returned no events) before publishing the stalled-source warning.

Useful? React with 👍 / 👎.

@3esmit
3esmit force-pushed the 3esmit/deps/runtime-pin-20260918 branch from ddf9bff to 1c2f12e Compare September 18, 2026 07:26
@3esmit
3esmit merged commit 3f9c180 into main Sep 18, 2026
9 checks passed
@3esmit
3esmit deleted the 3esmit/deps/runtime-pin-20260918 branch September 18, 2026 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: track upstream synchronization for Logos forks

2 participants