Skip to content

chore: consume reconciled blockchain module - #415

Merged
3esmit merged 2 commits into
mainfrom
3esmit/chore/pin-blockchain-module-59
Sep 17, 2026
Merged

3esmit merged 2 commits into
mainfrom
3esmit/chore/pin-blockchain-module-59

Conversation

@3esmit

@3esmit 3esmit commented Sep 17, 2026

Copy link
Copy Markdown
Owner

Summary

  • pin blockchain_module to the merged 3esmit/logos-blockchain-module PR fix(release): resolve Nix build root portably #59;
  • consume its merged logos-blockchain C API pin, including the disambiguated network-info exports;
  • refresh the lockfile without changing Inspector source behavior.

Fixes #414.

Validation

  • git diff --check
  • lockfile verifies blockchain_module at 405e4d859fcc3cf71b962df06146dfee8358e3d0 and nested logos-blockchain at a49c4cb4d20a58bd1d5e9817bcab31a854278cdb;
  • local Nix evaluation was attempted; the host Nix store reported a missing cached source path, so hosted CI is authoritative for the clean checkout.

Copilot AI lite review requested due to automatic review settings September 17, 2026 18:08

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 17, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-17T18:10:32.975409Z 975a6eb PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 975a6eb8ab

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread flake.nix
blockchain_module = {
# Testnet profile plus connected-peer IBD recovery.
url = "github:3esmit/logos-blockchain-module?rev=879b1839050a9a3eba6b0dbca97bc11848986897";
url = "github:3esmit/logos-blockchain-module?rev=405e4d859fcc3cf71b962df06146dfee8358e3d0";

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Update the release pin policy with the new revision

When this revision is checked by the build or release pipelines, scripts/check-release-workflow.py still requires the previous blockchain-module SHA in FORK_INPUTS (scripts/check-release-workflow.py:24-28). Consequently, python3 scripts/check-release-workflow.py rejects both the updated flake input and lock entry, and python3 -m unittest scripts.test_action_pins also fails, blocking the complete, core, and UI release preflight workflows until the policy pin is updated alongside this line.

Useful? React with 👍 / 👎.

@3esmit

3esmit commented Sep 17, 2026

Copy link
Copy Markdown
Owner Author

Policy follow-up: the release contract also pins the expected blockchain_module revision. Updated scripts/check-release-workflow.py to 405e4d859fcc3cf71b962df06146dfee8358e3d0; local python3 scripts/check-build-pipeline.py ci-policy now passes. This keeps the release workflow contract aligned with flake.nix/flake.lock.

@3esmit
3esmit merged commit 7f56f39 into main Sep 17, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: consume reconciled blockchain module

2 participants