Repository navigation
chore: consume reconciled blockchain module - #415
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 975a6eb8ab
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| blockchain_module = { | ||
| # Testnet profile plus connected-peer IBD recovery. | ||
| url = "github:3esmit/logos-blockchain-module?rev=879b1839050a9a3eba6b0dbca97bc11848986897"; | ||
| url = "github:3esmit/logos-blockchain-module?rev=405e4d859fcc3cf71b962df06146dfee8358e3d0"; |
There was a problem hiding this comment.
Update the release pin policy with the new revision
When this revision is checked by the build or release pipelines, scripts/check-release-workflow.py still requires the previous blockchain-module SHA in FORK_INPUTS (scripts/check-release-workflow.py:24-28). Consequently, python3 scripts/check-release-workflow.py rejects both the updated flake input and lock entry, and python3 -m unittest scripts.test_action_pins also fails, blocking the complete, core, and UI release preflight workflows until the policy pin is updated alongside this line.
Useful? React with 👍 / 👎.
|
Policy follow-up: the release contract also pins the expected |
Summary
blockchain_moduleto the merged3esmit/logos-blockchain-modulePR fix(release): resolve Nix build root portably #59;logos-blockchainC API pin, including the disambiguated network-info exports;Fixes #414.
Validation
git diff --checkblockchain_moduleat405e4d859fcc3cf71b962df06146dfee8358e3d0and nestedlogos-blockchainata49c4cb4d20a58bd1d5e9817bcab31a854278cdb;