Repository navigation
fix(source-routing): preserve execution-zone read diagnostics - #410
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Sep 15, 2026
3esmit
force-pushed
the
3esmit/fix-405-rpc-diagnostics
branch
5 times, most recently
from
September 16, 2026 16:02
35f894f to
0c79e0b
Compare
3esmit
force-pushed
the
3esmit/fix-405-rpc-diagnostics
branch
from
September 16, 2026 16:19
0c79e0b to
97173c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refs #405.
Source-routing adapters previously reduced every execution-zone read error to a category, so Basecamp and standalone could report only a generic health, identity, or head failure. The adapter now retains a bounded causal diagnostic and carries it into unavailable/protocol probe failures.
Verification
cargo fmt --all -- --checkcargo test --locked --lib source_routing::channel_sources::layer --no-fail-fastcargo test --locked --lib source_routing::channel_sources::probe --no-fail-fastcargo test --locked --lib inspection::l2::source --no-fail-fastcargo clippy --locked --lib --all-targets -- -D warningspython3 scripts/check-build-pipeline.py ci(passed)cargo-semver-checks 0.50.0againstorigin/main(223 pass, 31 skip)