Skip to content

fix(source-routing): preserve execution-zone read diagnostics - #410

Merged
3esmit merged 1 commit into
mainfrom
3esmit/fix-405-rpc-diagnostics
Sep 16, 2026
Merged

3esmit merged 1 commit into
mainfrom
3esmit/fix-405-rpc-diagnostics

Conversation

@3esmit

@3esmit 3esmit commented Sep 15, 2026

Copy link
Copy Markdown
Owner

Summary

Refs #405.

Source-routing adapters previously reduced every execution-zone read error to a category, so Basecamp and standalone could report only a generic health, identity, or head failure. The adapter now retains a bounded causal diagnostic and carries it into unavailable/protocol probe failures.

  • Preserve the full error chain up to 512 bytes.
  • Keep capability failures on the existing stable unsupported message.
  • Keep channel attestation, mismatch rejection, pending-source handling, retries, and endpoint validation unchanged.
  • Add regressions for causal propagation, truncation, and capability-message privacy.

Verification

  • cargo fmt --all -- --check
  • cargo test --locked --lib source_routing::channel_sources::layer --no-fail-fast
  • cargo test --locked --lib source_routing::channel_sources::probe --no-fail-fast
  • cargo test --locked --lib inspection::l2::source --no-fail-fast
  • cargo clippy --locked --lib --all-targets -- -D warnings
  • python3 scripts/check-build-pipeline.py ci (passed)
  • cargo-semver-checks 0.50.0 against origin/main (223 pass, 31 skip)
  • Existing Basecamp and standalone investigate(basecamp): Sequencer identity RPC fails while standalone succeeds #405 acceptance recheck remains green; this change only improves diagnostics on the failure path.

Copilot AI lite review requested due to automatic review settings September 15, 2026 22:05

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 15, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-16T16:21:16.447673Z 97173c3 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@3esmit
3esmit force-pushed the 3esmit/fix-405-rpc-diagnostics branch from 0c79e0b to 97173c3 Compare September 16, 2026 16:19
@3esmit
3esmit merged commit ce1558a into main Sep 16, 2026
9 checks passed
@3esmit
3esmit deleted the 3esmit/fix-405-rpc-diagnostics branch September 16, 2026 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants