fix(coordination): split AdvisoryLock into sync and async variants#9
Merged
Merged
Conversation
35C4n0r
commented
May 24, 2026
35C4n0r
commented
Owner
- the single AdvisoryLock class used sync with for try_acquire/release and async with for atry_acquire/arelease, but PostgresSaver._cursor() is a sync context manager and AsyncPostgresSaver._cursor() is async - mixing them caused TypeError at runtime
- split into SyncAdvisoryLock (PostgresSaver) and AsyncAdvisoryLock (AsyncPostgresSaver); each class only uses the cursor protocol that matches its checkpointer
- SyncAdvisoryLock.atry_acquire/arelease delegate to the sync methods so it remains usable from asweep() when paired with PostgresSaver
- AsyncAdvisoryLock.try_acquire/release raise NotImplementedError since AsyncPostgresSaver has no sync cursor path
- update get_advisory_lock() return type and sweeper.py annotation
- the single AdvisoryLock class used sync with for try_acquire/release and async with for atry_acquire/arelease, but PostgresSaver._cursor() is a sync context manager and AsyncPostgresSaver._cursor() is async - mixing them caused TypeError at runtime - split into SyncAdvisoryLock (PostgresSaver) and AsyncAdvisoryLock (AsyncPostgresSaver); each class only uses the cursor protocol that matches its checkpointer - SyncAdvisoryLock.atry_acquire/arelease delegate to the sync methods so it remains usable from asweep() when paired with PostgresSaver - AsyncAdvisoryLock.try_acquire/release raise NotImplementedError since AsyncPostgresSaver has no sync cursor path - update get_advisory_lock() return type and sweeper.py annotation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.