fix(sweeper): key threshold cache by TTLPolicy value instead of id()#11
Merged
Conversation
35C4n0r
commented
May 24, 2026
Owner
- id(policy) returns the CPython memory address, which is reused as soon as the previous policy object is freed; within a single _plan() loop a policy_resolver that creates a fresh TTLPolicy per thread can produce two different policies with the same id(), causing the cache to return thresholds computed for the wrong policy
- TTLPolicy is a frozen dataclass so it has hash and eq based on its fields; using the policy object itself as the dict key is correct and safe regardless of object identity
- id(policy) returns the CPython memory address, which is reused as soon as the previous policy object is freed; within a single _plan() loop a policy_resolver that creates a fresh TTLPolicy per thread can produce two different policies with the same id(), causing the cache to return thresholds computed for the wrong policy - TTLPolicy is a frozen dataclass so it has __hash__ and __eq__ based on its fields; using the policy object itself as the dict key is correct and safe regardless of object identity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.