fix: normalize non-2xx HTTP responses into ApiError objects#23
Open
dev-khimesh wants to merge 1 commit into
Open
fix: normalize non-2xx HTTP responses into ApiError objects#23dev-khimesh wants to merge 1 commit into
dev-khimesh wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Harden API response error handling: non-OK HTTP responses are now normalized into
ApiErrorobjects, run through the existing error interceptor chain, and thrown consistently.Changes
Before
request<T>()returned every HTTP response as a successfulApiResponse<T>, even 4xx/5xx responses. Callers had to duplicate status checks, and the error interceptor chain (401, 429 handlers) was never exercised for HTTP errors.After
request<T>()checksresponse.ok— non-2xx responses are parsed intoApiErrorand thrownmessage,error,details,suggestionfields) are safely extractednormalizeErrorhandlingRequired Validation
Closes #1