fix: normalize non-OK API responses#2
Closed
YfengJ wants to merge 2 commits into
Closed
Conversation
eb38a82 to
c481dd2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1.
Normalizes non-2xx HTTP responses in the shared frontend API client into
ApiErrorobjects so callers no longer receive 4xx/5xx responses as successfulApiResponse<T>values.Changes
fetchresponses intoApiErrorbefore the success response-interceptor path.normalizeErrorpath.diagnostic/build-b172b833.jsonfrom the requiredpython3 build.pyrun. The encrypted.logdcould not be created because the localencryptlypreflight fails before module builds.Testing
cd frontend && npm ci --ignore-scripts --no-audit --no-fundcd frontend && npm run buildpasses.git diff --checkpasses.python3 build.pywas run and failed in the required diagnostic preflight becauseencryptlycannot run in this environment. It generated and committeddiagnostic/build-b172b833.json; no.logdwas produced.Checklist