Support a coral-compatible backend + sidebar/tooling tidy#209
Merged
Conversation
- feat: make the local Coral plugin path a free-text field with a Browse button (accepts a plugin path or a value passed to -p, e.g. a comma-separated module list) - fix: stop the local probe requiring the Coral plugin path to be an existing file on disk - docs: note the field's dual use in run-coral-local.md and add a CHANGELOG entry
- feat: show the literal input for node_type "primitive" (NodeTypePyBackend.PRIMITIVE), not only elementary_constructor - fix: make numeric value validation null-safe so a null/empty primitive value no longer throws - docs: add CHANGELOG entry
- fix: validateGraphData accepts an 'any' target input, matching the live connection validation - test: add a coral-python functions graph + math registry fixture covering the any-typed print_result input
3 tasks
- fix: formatting changes now land in the same commit instead of being left unstaged after the commit was created
- chore: add lint-staged, scoped to *.{ts,svelte,js,json,md} staged files
- docs: update README, CLAUDE.md, CHANGELOG for the new pre-commit behaviour
- feat: add PRIMITIVE, METHOD and CONST_METHOD to NodeType so the canvas recognises the full CORAL node-type vocabulary emitted by both backends - fix: map const_method (and method) to UnifiedNode with a colour, closing the gap where they fell back to a broken default node - refactor: remove the separate NodeTypePyBackend enum, folding primitive/method into NodeType - docs: refresh the CHANGELOG entry and the CLAUDE.md node-type section
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of 2listic/coral-python#12
Overview
Platform-side support for reintegrating the coral-python backend as a coral-compatible
backend: from the app's perspective it stays
backendKind: coral; only the executable/pluginpaths differ. The coral-python side (a coral-style register/run CLI and a platform-native node
registry) is tracked in 2listic/coral-python#12. This PR covers the dealiiX-platform changes
needed to probe, render, and load that backend's graphs, plus a small unrelated sidebar tidy.
Also included, unrelated to the above: a pre-commit tooling fix. Prettier previously ran
after the commit was already created, leaving its formatting unstaged; it now runs via
lint-staged, scoped to staged files only, so the formatted result lands in the commit itself.Summary
.sopath or an opaque-pvalue (e.g. a comma-separated module list); the local probe nolonger requires it to be an existing file.
node_type: "primitive"render an editable literal (text, or checkbox forbooleans) like elementary constructors; numeric validation is null-safe.
any-typed input (e.g.print_result);import validation now accepts an
anytarget input, matching the live connection validation.it no longer requires a remote login and falls back to
graph.jsonwhen no project is loaded.Test plan
writable working dir → Save & Sync populates the sidebar, no skipped-node toasts.
any-typed input (e.g.print_result) → the edge into it is kept, not dropped as a type mismatch.git statusis clean afterward.