Make sure "self" outputs show up in the network.#56
Merged
Merged
Conversation
Collaborator
Author
|
With this, I can run the demo that I wanted to run with subnetworks. |
pogmat
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose dangling self outputs as external outputs of coral::Network nodes.
Previously, nested network interface construction ignored outputs with argument index -1, so a subnetwork containing only nodes with self outputs could end up with no external outputs at all. This also made it impossible to expose objects like Triangulation from a saved subnetwork unless they were wrapped by another node with a named argument output.