52 make mpi initalization plug in wide#53
Merged
Conversation
pogmat
marked this pull request as ready for review
March 17, 2026 08:28
Collaborator
Author
|
@luca-heltai, you can review and merge after testing it on MAC. |
1 task
luca-heltai
requested changes
Mar 18, 2026
| using namespace dealii; | ||
| using namespace coral; | ||
| using coral_test::ScopedTestOutputDir; | ||
| using MPI_Session = Utilities::MPI::MPI_InitFinalize; |
Collaborator
There was a problem hiding this comment.
This will fail with mpich, since MPI_Session is a reserved word. Maybe use also here MPI_Handle?
Collaborator
There was a problem hiding this comment.
On my mac, with the change suggested above, it works.
Collaborator
|
I'm unsure why this keeps not running the tests: I still get Any idea? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
depends on #49
Please test on MAC.