Skip to content

52 make mpi initalization plug in wide#53

Merged
luca-heltai merged 21 commits into
mainfrom
52-make-mpi-initalization-plug-in-wide
Mar 21, 2026
Merged

52 make mpi initalization plug in wide#53
luca-heltai merged 21 commits into
mainfrom
52-make-mpi-initalization-plug-in-wide

Conversation

@pogmat

@pogmat pogmat commented Mar 13, 2026

Copy link
Copy Markdown
Collaborator

depends on #49

Please test on MAC.

@pogmat pogmat linked an issue Mar 13, 2026 that may be closed by this pull request
@pogmat
pogmat marked this pull request as draft March 13, 2026 17:41
@pogmat
pogmat requested a review from luca-heltai March 13, 2026 17:41
@pogmat
pogmat marked this pull request as ready for review March 17, 2026 08:28
@pogmat

pogmat commented Mar 17, 2026

Copy link
Copy Markdown
Collaborator Author

@luca-heltai, you can review and merge after testing it on MAC.

Comment thread backends/dealii/tests/dealii_mpi.cc Outdated
using namespace dealii;
using namespace coral;
using coral_test::ScopedTestOutputDir;
using MPI_Session = Utilities::MPI::MPI_InitFinalize;

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will fail with mpich, since MPI_Session is a reserved word. Maybe use also here MPI_Handle?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On my mac, with the change suggested above, it works.

@luca-heltai

Copy link
Copy Markdown
Collaborator

I'm unsure why this keeps not running the tests:

CORAL_KEEP_LONG_TEST=1 mpirun -np 2 ./backends/dealii/tests/dealii_mpi_tests

I still get

Running main() from /var/folders/1s/vn3tmrzs2_gb9jgfxgr2q4bc0000gn/T/dealii/spack-stage/spack-stage-googletest-1.17.0-ggbxmdopunamrltc6n7sk7q75jqfspri/spack-src/googletest/src/gtest_main.cc
[==========] Running 3 tests from 1 test suite.
[----------] Global test environment set-up.
[----------] 3 tests from DealiiMPITest
Running main() from /var/folders/1s/vn3tmrzs2_gb9jgfxgr2q4bc0000gn/T/dealii/spack-stage/spack-stage-googletest-1.17.0-ggbxmdopunamrltc6n7sk7q75jqfspri/spack-src/googletest/src/gtest_main.cc
[==========] Running 3 tests from 1 test suite.
[----------] Global test environment set-up.
[----------] 3 tests from DealiiMPITest
	coral_active_logger 0x0, coral_active_plugin_name dealii
	coral_active_logger 0x0, coral_active_plugin_name dealii
[ RUN      ] DealiiMPITest.Setup
[       OK ] DealiiMPITest.Setup (0 ms)
[ RUN      ] DealiiMPITest.LaplaceProblem
Skip On
/src/backends/dealii/tests/dealii_mpi.cc:98: Skipped
Long test and CORAL_KEEP_LONG_TEST disable. Skipping.

[  SKIPPED ] DealiiMPITest.LaplaceProblem (0 ms)
[ RUN      ] DealiiMPITest.LaplaceProblemNetwork
[ RUN      ] DealiiMPITest.Setup
[       OK ] DealiiMPITest.Setup (0 ms)
[ RUN      ] DealiiMPITest.LaplaceProblem
Skip On
/src/backends/dealii/tests/dealii_mpi.cc:98: Skipped
Long test and CORAL_KEEP_LONG_TEST disable. Skipping.

[  SKIPPED ] DealiiMPITest.LaplaceProblem (0 ms)
Skip On
/src/backends/dealii/tests/dealii_mpi.cc:114: Skipped
Long test and CORAL_KEEP_LONG_TEST disable. Skipping.

[  SKIPPED ] [ RUN      ] DealiiMPITest.LaplaceProblemNetwork
Skip On
DealiiMPITest.LaplaceProblemNetwork (0 ms)
/src/backends/dealii/tests/dealii_mpi.cc:114: Skipped
Long test and CORAL_KEEP_LONG_TEST disable. Skipping.

[  SKIPPED ] DealiiMPITest.LaplaceProblemNetwork (0 ms)
[----------] 3 tests from DealiiMPITest (0 ms total)

[----------] Global test environment tear-down
[==========] 3 tests from 1 test suite ran. (41 ms total)
[  PASSED  ] 1 test.
[  SKIPPED ] 2 tests, listed below:
[  SKIPPED ] DealiiMPITest.LaplaceProblem
[  SKIPPED ] DealiiMPITest.LaplaceProblemNetwork
[----------] 3 tests from DealiiMPITest (0 ms total)

[----------] Global test environment tear-down
[==========] 3 tests from 1 test suite ran. (41 ms total)
[  PASSED  ] 1 test.
[  SKIPPED ] 2 tests, listed below:
[  SKIPPED ] DealiiMPITest.LaplaceProblem
[  SKIPPED ] DealiiMPITest.LaplaceProblemNetwork

Any idea?

@luca-heltai
luca-heltai merged commit 87511c3 into main Mar 21, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make MPI Initalization plug-in wide.

2 participants