Skip to content

41 use qualified id to generate node status files#44

Merged
pogmat merged 5 commits into
mainfrom
41-use-qualified_id-to-generate-node-status-files
Feb 12, 2026
Merged

41 use qualified id to generate node status files#44
pogmat merged 5 commits into
mainfrom
41-use-qualified_id-to-generate-node-status-files

Conversation

@pogmat

@pogmat pogmat commented Feb 11, 2026

Copy link
Copy Markdown
Collaborator

@pcolt, @mfranzon: behavior of BE for qualified_id in jsons.

Scenario Action Serialized to JSON Available at Runtime Notes
qualified_id present and unique Use as-is Yes Yes Normal case - user-provided ID used everywhere
qualified_id missing Auto-generate <node_id>_auto_<counter> No Yes Backward compatible - warning logged, ID available for touch files/logs but transient
qualified_id duplicated Throw DuplicateQualifiedIdException N/A N/A Network loading fails with fatal error, main program terminates gracefully

@pogmat pogmat linked an issue Feb 11, 2026 that may be closed by this pull request
@pogmat
pogmat marked this pull request as draft February 11, 2026 18:41
@mfranzon

Copy link
Copy Markdown
Collaborator

@pcolt, @mfranzon: behavior of BE for qualified_id in jsons.

Scenario Action Serialized to JSON Available at Runtime Notes
qualified_id present and unique Use as-is Yes Yes Normal case - user-provided ID used everywhere
qualified_id missing Auto-generate <node_id>_auto_<counter> No Yes Backward compatible - warning logged, ID available for touch files/logs but transient
qualified_id duplicated Throw DuplicateQualifiedIdException N/A N/A Network loading fails with fatal error, main program terminates gracefully

LGTM!

@pogmat

pogmat commented Feb 12, 2026

Copy link
Copy Markdown
Collaborator Author

@pcolt is the following the content of touch dir that you expect for your graph?

0.running
0.succeeded
12_10.running
12_10.succeeded
12_11.running
12_11.succeeded
12_3.running
12_3.succeeded
12_5.running
12_5.succeeded
12_8.running
12_8.succeeded
12.running
12.succeeded
1.running
1.succeeded
2.running
2.succeeded
6.running
6.succeeded
9.running
9.succeeded

If it is, I'll merge the PR.

@pcolt

pcolt commented Feb 12, 2026

Copy link
Copy Markdown
Collaborator

@pcolt is the following the content of touch dir that you expect for your graph?

Yes, it is

@pogmat
pogmat marked this pull request as ready for review February 12, 2026 13:56
@pogmat
pogmat merged commit 9ab7bc2 into main Feb 12, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use qualified_id to generate node status files

3 participants