[#79] Implementing share deep linking | Event screen#94
Open
maximspics wants to merge 22 commits into
Open
Conversation
…thub.com/2jumper3/DoSport into (iOS-48)-Implement-Share-in-Event-screen # Conflicts: # DoSport/DoSport.xcodeproj/project.pbxproj
komolbek
changed the title
komolbek
requested changes
Mar 20, 2021
| case FeedCoordinator | ||
| } | ||
|
|
||
| final class DeepLinkManager { |
Collaborator
There was a problem hiding this comment.
лучше создай какой нибудь протокол для этого класса, что бы на него не ссылаться напрямую
Collaborator
Author
There was a problem hiding this comment.
Сделано. Но ты проверь.
| func handleURL(_ url: URL, _ appCoordinator: AppCoordinator?) { | ||
| guard url.pathComponents.count >= 2 else { return } | ||
|
|
||
| let idFromUrl = url.pathComponents.last |
Collaborator
Author
There was a problem hiding this comment.
Это универсальный айди, который используется для перехода на нужный еветн, профиль и т.п. (то, на что мы будем делать диплинки).
Collaborator
There was a problem hiding this comment.
тогда напиши что то типа eventID , что было понятно id чего. А в то контексте класса AppDelegate может показаться, что это его свойство.
# Conflicts: # DoSport/DoSport/Application/AppDelegate.swift # DoSport/DoSport/Application/SceneDelegate.swift
# Conflicts: # DoSport/DoSport.xcodeproj/project.pbxproj # DoSport/DoSport/Application/AppDelegate.swift
…thub.com/2jumper3/DoSport into (iOS-48)-Implement-Share-in-Event-screen # Conflicts: # DoSport/DoSport.xcodeproj/project.pbxproj # DoSport/DoSport/Application/AppDelegate.swift
…thub.com/2jumper3/DoSport into (iOS-48)-Implement-Share-in-Event-screen
# Conflicts: # DoSport/DoSport.xcodeproj/project.pbxproj # DoSport/DoSport/Application/AppDelegate.swift
…thub.com/2jumper3/DoSport into (iOS-48)-Implement-Share-in-Event-screen # Conflicts: # DoSport/DoSport.xcodeproj/project.pbxproj # DoSport/DoSport/Application/AppDelegate.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.