Porting internode test from DeepEP to NixlEP - #1
Open
2dm wants to merge 2 commits into
Open
Conversation
Co-authored-by: Roey Azran <roeya@nvidia.com>
2dm
commented
Jan 29, 2026
| @@ -0,0 +1,23 @@ | |||
| #pragma once | |||
| #ifdef ENABLE_DEBUG_LOGS | |||
Owner
Author
There was a problem hiding this comment.
Consider removing logging completely. internode.cu is full of logging we previously added. The excess prints are not useful for debugging. It is also not aligned with elastic example and upstream DeepEp.
2dm
commented
Jan 29, 2026
|
|
||
| # Initialize NIXL buffer with group (for IPC handles) and TCPStore (for NIXL metadata) | ||
| print(f"pid: {os.getpid()}, rank: {rank}, num_ranks: {num_ranks}, initializing buffer", flush=True) | ||
| buffer = nixl_ep.Buffer(rank=rank, low_latency_mode=False, explicitly_destroy=True, group=group, tcp_store_group=tcp_store, nvlink_backend="ipc") |
Owner
Author
There was a problem hiding this comment.
We have not supported low_latency_mode before. If we plan to support it, we should assign args.test_ll_compatibility to it.
Owner
Author
There was a problem hiding this comment.
Or consider to remove it completely from internode and diverge more from DeepEp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding high throughput internode test to NIXL examples