Upgrade all dependencies + add TS-Reset - #19
Open
keichinger wants to merge 3 commits into
Open
Conversation
…bally available This is also recommended by TS-Reset itself, as this may or may not interfere badly when used in third-party code bases that don’t even want to use TS-Reset.
apfelbox
requested changes
Sep 2, 2024
| @@ -1,2 +1,4 @@ | |||
| /_init/**/node_modules | |||
| /_init/**/pnpm-lock.yaml | |||
Member
There was a problem hiding this comment.
We shouldn't need that, as the deploy step rebuilds the project without installing it.
Contributor
Author
There was a problem hiding this comment.
This is purely for our own maintenance sakes, as it seems way easier and more intuitive to just cd into each starter type and type pnpm update to bump the versions accordingly.
Member
There was a problem hiding this comment.
I am not super happy with adding these, as they are not really required and might hide issues.
If you need a more comfortable way to update the deps, you should rather use something like https://www.npmjs.com/package/npm-check-updates instead.
| cwd: sourceDir, | ||
| dot: true, | ||
| nodir: true, | ||
| ignore: [ |
Member
There was a problem hiding this comment.
Here as well: we should not need this, as there is no node_modules in this directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.