Conversation
AirKyzzZ
marked this pull request as draft
August 12, 2026 14:16
genaris
reviewed
Aug 12, 2026
genaris
left a comment
Member
There was a problem hiding this comment.
Some initial comments on the PR before going deeper:
- I don't understand the need of that new "VERANA_TESTNET" environment variable. Why don't we just leave it as it is right now? We already know current status is temporary
- We are not using unit tests on this repo, so I prefer not to add these .test.ts files (that require node setup)
Whenever possible, try to introduce as little changes as possible, even if you feel there are some useful improvements over existing code (verre configuration for example). This is mostly to make the review easier (since Hologram codebase is quite complex right now). I think we are going to completely refactor the whole feature once v4 lands (e.g. new concepts, direct usage of indexer API, etc.).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Verana integration for Hologram, 10 commits: the trust card on the chat surface with Q1 identity resolution (ECS-Service x ECS-Org), the Q2/Q3 accreditation checks against the permission module, the UNVERIFIED state, and the consent gate on the connection flow. Hologram already carried the Q1 check, so this brings it to parity with the other integrated wallets (accreditation card + gate + v3 design). Demoed against the playground testnet cast. Merges clean on
main.