Skip to content

Harden protocol hook lifecycle#20

Closed
1vivy wants to merge 2 commits into
mainfrom
feature/hook-lifecycle-safety
Closed

Harden protocol hook lifecycle#20
1vivy wants to merge 2 commits into
mainfrom
feature/hook-lifecycle-safety

Conversation

@1vivy

@1vivy 1vivy commented May 14, 2026

Copy link
Copy Markdown
Owner

Summary

  • Add protocol hook rollback/uninstall paths for failure cleanup while keeping hooks active for successful chainloaded ABL handoff.
  • Add a same-session hook registry to avoid blind double-wrapping and fail closed on cross-mode reuse or registry install failure.
  • Add lifecycle lint coverage and document the warm-reset Fastboot hang audit.

Validation

  • git diff --check
  • tests/045_mode_taxonomy_lint.sh
  • tests/046_mode1_protocol_hook_lint.sh
  • tests/047_cleanup_lint.sh
  • tests/048_hook_lifecycle_lint.sh
  • ./scripts/build.sh --mode 0
  • ./scripts/build.sh --mode 1

Notes

Copilot AI review requested due to automatic review settings May 14, 2026 21:22

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@1vivy
1vivy force-pushed the feature/hook-lifecycle-safety branch from 315a93a to 11896a3 Compare May 14, 2026 21:30
@1vivy
1vivy requested a review from Copilot May 14, 2026 21:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@1vivy

1vivy commented May 14, 2026

Copy link
Copy Markdown
Owner Author

Superseded by #21, which keeps the same-session hook safety guard as a smaller detect-only/fail-closed registry and drops the broader uninstall/rollback lifecycle machinery.

@1vivy 1vivy closed this May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants