Skip to content

Refine notification events and Telegram delivery#10

Merged
120318 merged 4 commits into
mainfrom
feature/telegram-notifications
Jun 3, 2026
Merged

Refine notification events and Telegram delivery#10
120318 merged 4 commits into
mainfrom
feature/telegram-notifications

Conversation

@120318

@120318 120318 commented Jun 3, 2026

Copy link
Copy Markdown
Owner

Summary

  • Replace legacy alerts with the notification center backed by event acknowledgements and action state.
  • Rework event boundaries so operation lifecycle records stay in commands/actions while Telegram only receives business events.
  • Add Telegram channel support with localized, user-facing messages and an [Aethera] sender marker.
  • Add migrations to remove alerts storage and prune operation-only/subscription-run audit events.
  • Tighten subscription resource selection after torrent payload verification so later candidates are still considered.

Validation

  • ./scripts/review_with_gates.sh

Notes

  • PR descriptions for Aethera are written in English by project workflow.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review


P2 Badge 改用 ConfigDialog 支持的 v-model

ConfigDialog 只声明了 modelValue 并发出 update:modelValue,所以这里的 v-model:visible 传入的是一个被忽略的 visible prop;点击“编辑”或启用后设置 dialogVisible 也不会打开通知配置弹窗,下方的频道弹窗同样如此。请改成默认 v-model,或显式使用 :model-value / @update:model-value

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread backend/app/db/repositories/event_repository.py Outdated
Comment thread backend/app/services/integration/notifications/channels/telegram/renderer.py Outdated
Comment thread backend/app/services/application/workflows/scheduled_transfer/service.py Outdated

120318 commented Jun 3, 2026

Copy link
Copy Markdown
Owner Author

Addressed the review findings in c205dc3:

  • Made event acknowledgement idempotent with SQLite ON CONFLICT DO NOTHING.
  • Changed Telegram detail links to use the frontend-recognized season query parameter.
  • Added a source visibility grace period for scheduled transfers; tasks with sources still missing after the grace period are enqueued so the transfer failure path records a visible error/event.
  • Switched notification configuration dialogs from v-model:visible to the supported default v-model.

Validation: ./scripts/review_with_gates.sh passed.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c205dc35f6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread frontend/src/components/config/SystemConfig.vue
Comment thread backend/app/db/repositories/event_repository.py Outdated
Comment thread backend/app/services/integration/notifications/channels/telegram/renderer.py Outdated
Comment thread backend/app/services/config/indexer_client_settings.py Outdated

120318 commented Jun 3, 2026

Copy link
Copy Markdown
Owner Author

Addressed the latest review follow-ups in 29e4f89:

  • Preserved locale and public_base_url in the system tab response so partial system saves do not reset notification language or public links.
  • Switched bulk event acknowledgement to SQLite insert-or-ignore and return the actual inserted acknowledgement count.
  • Caught transfer precheck TransferExceptions in the scheduled transfer workflow and marked the task with visible transfer-stage failure details.
  • Escaped * for Telegram MarkdownV2 and kept indexer failure reasons visible in rendered notifications.
  • Added an indexer.site.unhealthy warning event at the consecutive-failure threshold, including default notification patterns, frontend event metadata, and backend/frontend translations.

Validation: ./scripts/review_with_gates.sh passed.

@120318
120318 merged commit 867d56f into main Jun 3, 2026
1 check passed
@120318
120318 deleted the feature/telegram-notifications branch June 3, 2026 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant