Migrate ESLint config to flat config and fix linting on fork PRs - #1406
Open
adamsilverstein wants to merge 2 commits into
Open
adamsilverstein wants to merge 2 commits into
adamsilverstein wants to merge 2 commits into
Conversation
@wordpress/scripts 35 runs ESLint 9, which ignores .eslintrc.json and .eslintignore. The repo config, ignores and Cypress globals were silently dropped, leaving 655 errors on develop. Port them to eslint.config.js, bump eslint-plugin-cypress to 3.6 for its flat config, and fix the few real issues the newer rules report. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MWLpjMiZ5cyR6nBxhTz9z7
The annotate action needs checks: write, which fork PR tokens never have, so the eslint job always failed on forks. Fail on the lint step directly for forks instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MWLpjMiZ5cyR6nBxhTz9z7
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while chasing a red eslint check on #1405. Claude tracked down the cause and wrote the fix:
Changelog Entry
Credits
Props @adamsilverstein
AI Use
Claude Code wrote both the config migration and this description. I will review and test.
🤖 Generated with Claude Code
https://claude.ai/code/session_01MWLpjMiZ5cyR6nBxhTz9z7