[TECH] sinon.restore() entre chaque test dans les fronts

admin/tests/integration/components/administration/access/anonymize-gar-import-test.gjs

@@ -24,10 +24,6 @@ module('Integration | Component |  administration/anonymize-gar-import', functio
     sinon.stub(window, 'fetch');
   });
 
-  hooks.afterEach(function () {
-    sinon.restore();
-  });
-
   module('when import fully succeeds', function () {
     test('it displays a success notification', async function (assert) {
       // given

admin/tests/integration/components/administration/common/create-attestations-test.gjs

@@ -20,10 +20,6 @@ module('Integration | Component | administration/create-attestations', function
     sinon.stub(requestManagerService, 'request');
   });
 
-  hooks.afterEach(function () {
-    sinon.restore();
-  });
-
   module('when all fields are filled', function () {
     test('it should enable submit button', async function (assert) {
       const screen = await render(<template><CreateAttestations /></template>);

admin/tests/integration/components/administration/common/user-quest-checker-test.gjs

@@ -12,10 +12,6 @@ import setupIntlRenderingTest from '../../../../helpers/setup-intl-rendering';
 module('Integration | Component |  administration/user-quest-checker', function (hooks) {
   setupIntlRenderingTest(hooks);
 
-  hooks.afterEach(function () {
-    sinon.restore();
-  });
-
   test('it should display a form', async function (assert) {
     // when
     const screen = await render(<template><UserQuestChecker /></template>);

admin/tests/integration/components/administration/deployment/certification-centers-batch-archive-test.gjs

@@ -15,10 +15,6 @@ module('Integration | Component | administration/certification-centers-batch-arc
     sinon.stub(window, 'fetch');
   });
 
-  hooks.afterEach(function () {
-    sinon.restore();
-  });
-
   module('when batch archive succeeds', function () {
     test('it displays a success notification', async function (assert) {
       // given

admin/tests/integration/components/administration/deployment/organizations-batch-archive-test.gjs

@@ -17,10 +17,6 @@ module('Integration | Component | administration/organizations-batch-archive', f
     sinon.stub(requestManagerService, 'request');
   });
 
-  hooks.afterEach(function () {
-    sinon.restore();
-  });
-
   module('when batch archive succeeds', function () {
     test('it displays the correct number of archived organizations in success notification', async function (assert) {
       // given

admin/tests/integration/components/administration/deployment/update-organizations-in-batch-test.gjs

@@ -24,10 +24,6 @@ module('Integration | Component |  administration/update-organizations-in-batch'
     sinon.stub(window, 'fetch');
   });
 
-  hooks.afterEach(function () {
-    sinon.restore();
-  });
-
   module('when import succeeds', function () {
     test('it displays a success notification', async function (assert) {
       // given

admin/tests/integration/components/certification-centers/membership-item-test.gjs

@@ -18,10 +18,6 @@ module('Integration | Component |  certification-centers/membership-item', funct
     intl = this.owner.lookup('service:intl');
   });
 
-  hooks.afterEach(function () {
-    sinon.restore();
-  });
-
   module('displays a certification center membership table row item', function () {
     test('with last access date if exists', async function (assert) {
       // given

admin/tests/integration/components/certifications/certification/informations/global-actions-test.gjs

@@ -923,11 +923,7 @@ module('Integration | Component | Certifications | Certification | Information |
       });
     });
 
-    module('when button is displayed', function (hooks) {
-      hooks.afterEach(function () {
-        sinon.restore();
-      });
-
+    module('when button is displayed', function () {
       test('should trigger rescoring and show success notification', async function (assert) {
         assert.expect(1);
 

admin/tests/integration/components/organizations/member-item-test.gjs

@@ -20,10 +20,6 @@ module('Integration | Component | MemberItem', function (hooks) {
     currentUser.adminMember = { isSuperAdmin: true };
   });
 
-  hooks.afterEach(function () {
-    sinon.restore();
-  });
-
   test('displays an organization member details', async function (assert) {
     // given
     const member = {

admin/tests/integration/components/users/certification-centers/membership-item-test.gjs

@@ -16,9 +16,6 @@ module('Integration | Component | users | certification-centers | membership-ite
     store = this.owner.lookup('service:store');
   });
 
-  hooks.afterEach(function () {
-    sinon.restore();
-  });
   module('displays a certification center membership table row item', function () {
     test('with last access date if there is one', async function (assert) {
       // given

admin/tests/test-helper.js

@@ -3,6 +3,7 @@ import { clearAllCookies } from 'ember-cookies/test-support';
 import start from 'ember-exam/test-support/start';
 import * as QUnit from 'qunit';
 import { setup } from 'qunit-dom';
+import sinon from 'sinon';
 
 import Application from '../app';
 import config from '../config/environment';
@@ -17,6 +18,11 @@ QUnit.hooks.beforeEach(function () {
   clearAllCookies();
 });
 
+// Restore all sinon stubs after each test to avoid side-effects
+QUnit.hooks.afterEach(function () {
+  sinon.restore();
+});
+
 setup(QUnit.assert);
 setApplication(Application.create(config.APP));
 start();

admin/tests/unit/authenticators/oidc-test.js

@@ -60,10 +60,6 @@ module('Unit | Authenticator | oidc', function (hooks) {
       oidcIdentityProvidersService.set('store', storeStub);
     });
 
-    hooks.afterEach(function () {
-      sinon.restore();
-    });
-
     test('fetches token with authentication key', async function (assert) {
       // given
       const authenticator = this.owner.lookup('authenticator:oidc');

admin/tests/unit/controllers/authenticated/sessions/session/informations-test.js

@@ -190,10 +190,6 @@ module('Unit | Controller | authenticated/sessions/session/informations', functi
       const adapter = store.adapterFor('session');
       getDownloadLinkStub = sinon.stub(adapter, 'getDownloadLink');
     });
-    hooks.afterEach(function () {
-      sinon.restore();
-    });
-
     test('it should retrieve link from api and copy it', async function (assert) {
       // given
       const session = sinon.stub();

admin/tests/unit/metrics-adapters/plausible-adapter-test.js

@@ -16,6 +16,7 @@ module('Unit | MetricsAdapter | plausible-adapter', function (hooks) {
   });
 
   hooks.afterEach(function () {
+    sinon.restore(); // must restore before uninstall, which deletes window.plausible
     this.adapter.uninstall();
   });
 

admin/tests/unit/routes/authenticated/target-profiles/list-test.js

@@ -26,10 +26,6 @@ module('Unit | Route | authenticated/target-profiles/list', function (hooks) {
       };
     });
 
-    hooks.afterEach(function () {
-      sinon.restore();
-    });
-
     module('when queryParams filters are falsy', function () {
       test('it should call store.query with no filters on name and id', async function (assert) {
         // when

admin/tests/unit/routes/authenticated/users/get-test.js

@@ -5,11 +5,7 @@ import sinon from 'sinon';
 module('Unit | Route | authenticated/users/get', function (hooks) {
   setupTest(hooks);
 
-  module('beforeModel', function (hooks) {
-    hooks.afterEach(function () {
-      sinon.restore();
-    });
-
+  module('beforeModel', function () {
     test('loads all available identity providers', async function (assert) {
       // given
       const route = this.owner.lookup('route:authenticated/users/get');

admin/tests/unit/routes/authentication/login-oidc-test.js

@@ -30,10 +30,6 @@ module('Unit | Route | login-oidc', function (hooks) {
         oidcIdentityProvidersService.set('store', storeStub);
       });
 
-      hooks.afterEach(function () {
-        sinon.restore();
-      });
-
       module('when identity provider is not supported', function () {
         test('redirects the user to main login page', async function (assert) {
           // given
@@ -65,7 +61,6 @@ module('Unit | Route | login-oidc', function (hooks) {
           );
           sinon.assert.calledWith(replaceStub, 'https://oidc.example.net/connexion');
           assert.ok(true);
-          sinon.restore();
         });
       });
     });

admin/tests/unit/routes/login-test.js

@@ -10,11 +10,7 @@ module('Unit | Route | login', function (hooks) {
     assert.ok(route);
   });
 
-  module('model', function (hooks) {
-    hooks.afterEach(function () {
-      sinon.restore();
-    });
-
+  module('model', function () {
     test('loads ready identity providers', async function (assert) {
       // given
       const route = this.owner.lookup('route:login');

admin/tests/unit/services/current-domain-test.js

@@ -5,10 +5,6 @@ import sinon from 'sinon';
 
 module('Unit | Service | currentDomain', function (hooks) {
   setupTest(hooks);
-  hooks.afterEach(function () {
-    sinon.restore();
-  });
-
   module('#getExtension', function () {
     module('when location is FR TLD', function () {
       test(`returns fr`, function (assert) {

admin/tests/unit/services/pix-metrics-test.js

@@ -17,10 +17,6 @@ module('Unit | Service | PixMetrics', function (hooks) {
     sinon.stub(metricsService, 'trackEvent');
   });
 
-  hooks.afterEach(function () {
-    sinon.restore();
-  });
-
   module('trackPage', function () {
     test('it should redact id from url', function (assert) {
       // given

admin/tests/unit/services/request-manager-test.js

@@ -21,10 +21,6 @@ module('Unit | Service | request-manager', function (hooks) {
     sinon.stub(localeService, 'acceptLanguageHeader').value('fr');
   });
 
-  hooks.afterEach(function () {
-    sinon.restore();
-  });
-
   module('request()', function () {
     test('it requests successfully with default headers', async function (assert) {
       // given

admin/tests/unit/utils/location-test.js

@@ -2,11 +2,7 @@ import Location from 'pix-admin/utils/location';
 import { module, test } from 'qunit';
 import sinon from 'sinon';
 
-module('Unit | Utility | location', function (hooks) {
-  hooks.afterEach(function () {
-    sinon.restore();
-  });
-
+module('Unit | Utility | location', function () {
   module('#getHref', function () {
     test('should return the full URL', function (assert) {
       // given

certif/tests/integration/components/auth/register-form-test.js

@@ -160,10 +160,6 @@ module('Integration | Component | Auth::RegisterForm', function (hooks) {
       store = this.owner.lookup('service:store');
     });
 
-    hooks.afterEach(function () {
-      sinon.restore();
-    });
-
     async function _fillValidForm() {
       await fillByLabel(firstNameInputLabel, 'Alain');
       await fillByLabel(lastNameInputLabel, 'Ternational');

certif/tests/integration/components/members-list-test.js

@@ -20,10 +20,6 @@ module('Integration | Component | MembersList', function (hooks) {
     sinon.stub(currentUser, 'currentAllowedCertificationCenterAccess').value({ name: 'Certif NextGen' });
   });
 
-  hooks.afterEach(function () {
-    sinon.restore();
-  });
-
   module('For edit role button', function () {
     test('displays a modal', async function (assert) {
       // given

certif/tests/integration/components/members-table-test.gjs

@@ -17,10 +17,6 @@ module('Integration | Component | Members Table', function (hooks) {
     currentUser = this.owner.lookup('service:current-user');
   });
 
-  hooks.afterEach(function () {
-    sinon.restore();
-  });
-
   test('it displays members firstName, lastName and role', async function (assert) {
     // given
     const memberWithMemberRole = store.createRecord('member', {

certif/tests/integration/components/team/invitations-list-test.js

@@ -23,10 +23,6 @@ module('Integration | Component |  team/invitation-list', function (hooks) {
     this.set('resendInvitation', resendInvitation);
   });
 
-  hooks.afterEach(function () {
-    sinon.restore();
-  });
-
   test('displays email address, last sending date and actions headers', async function (assert) {
     // given
     const invitation = store.createRecord('certification-center-invitation', {

certif/tests/integration/components/team/modal/remove-member-modal-test.js

@@ -8,10 +8,6 @@ import setupIntlRenderingTest from '../../../../helpers/setup-intl-rendering';
 module('Integration | Components | Team::Modal::RemoveMemberModal', function (hooks) {
   setupIntlRenderingTest(hooks);
 
-  hooks.afterEach(function () {
-    sinon.restore();
-  });
-
   module('when the modal is open', function (hooks) {
     let screen;
     let closeRemoveMembershipModal, onRemoveButtonClicked;

certif/tests/test-helper.js

@@ -3,6 +3,7 @@ import { clearAllCookies } from 'ember-cookies/test-support';
 import start from 'ember-exam/test-support/start';
 import * as QUnit from 'qunit';
 import { setup } from 'qunit-dom';
+import sinon from 'sinon';
 
 import Application from '../app';
 import config from '../config/environment';
@@ -17,6 +18,11 @@ QUnit.hooks.beforeEach(function () {
   clearAllCookies();
 });
 
+// Restore all sinon stubs after each test to avoid side-effects
+QUnit.hooks.afterEach(function () {
+  sinon.restore();
+});
+
 setApplication(Application.create(config.APP));
 setup(QUnit.assert);
 start();

certif/tests/unit/controllers/authenticated/team/list-test.js

@@ -17,10 +17,6 @@ module('Unit | Controller | authenticated/team/list', function (hooks) {
     store = this.owner.lookup('service:store');
   });
 
-  hooks.afterEach(function () {
-    sinon.restore();
-  });
-
   module('#shouldDisplayNoRefererSection', function () {
     module('when certification center has CLEA habilitation', function (hooks) {
       hooks.beforeEach(function () {

certif/tests/unit/controllers/authenticated/team/list/invitations-test.js

@@ -16,10 +16,6 @@ module('Unit | Controller | authenticated/team/list/invitations', function (hook
     controller = this.owner.lookup('controller:authenticated/team/list/invitations');
   });
 
-  hooks.afterEach(function () {
-    sinon.restore();
-  });
-
   module('#cancelInvitation', function () {
     test('cancel invitation and displays a success notification', async function (assert) {
       // given

certif/tests/unit/controllers/authenticated/team/list/members-test.js

@@ -16,10 +16,6 @@ module('Unit | Controller | authenticated/team/list/members', function (hooks) {
     store = this.owner.lookup('service:store');
   });
 
-  hooks.afterEach(function () {
-    sinon.restore();
-  });
-
   module('#leaveCertificationCenter', function () {
     test('deletes the current user membership', async function (assert) {
       // given

certif/tests/unit/instance-initializers/session-test.js

@@ -23,7 +23,6 @@ module('Unit | Instance Initializer | session', function (hooks) {
   hooks.afterEach(function () {
     this.instance.destroy();
     this.application.destroy();
-    sinon.restore();
   });
 
   module('when a session exists', function () {

certif/tests/unit/metrics-adapters/plausible-adapter-test.js

@@ -17,6 +17,8 @@ module('Unit | MetricsAdapter | plausible-adapter', function (hooks) {
   });
 
   hooks.afterEach(function () {
+    // stubs must be restored before uninstalling the adapter, which removes `window.plausible`
+    sinon.restore();
     this.adapter.uninstall();
   });
 

certif/tests/unit/routes/application-test.js

@@ -14,10 +14,6 @@ module('Unit | Route | application', function (hooks) {
     sinon.stub(this.route.currentUser, 'load').resolves();
   });
 
-  hooks.afterEach(function () {
-    sinon.restore();
-  });
-
   module('beforeModel', function () {
     test('sets best locale', async function (assert) {
       // given