Skip to content

[TECH] Correction de tests flakies #17140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bpetetot merged 2 commits into from
Aug 14, 2026
+10 −5
Merged

[TECH] Correction de tests flakies #17140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1925244
test(api): fix flaky in jury-session-repository_test.js
bpetetot Aug 14, 2026
cc29dc6
test(admin): fix flaky in head-information-test.gjs
bpetetot Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion admin/tests/integration/components/organizations/head-information-test.gjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { render } from '@1024pix/ember-testing-library';
import EmberObject from '@ember/object';
import { triggerEvent } from '@ember/test-helpers';
import { settled, triggerEvent, waitUntil } from '@ember/test-helpers';
import { t } from 'ember-intl/test-support';
import HeadInformation from 'pix-admin/components/organizations/head-information';
import ENV from 'pix-admin/config/environment';
Expand Down Expand Up @@ -181,6 +181,8 @@ module('Integration | Component | organizations/header-information', function (h
files: [file],
},
);
await waitUntil(() => notificationService.sendSuccessNotification.calledOnce);
await settled();

// then
assert.true(organization.save.calledOnce);
Expand Down Expand Up @@ -217,6 +219,7 @@ module('Integration | Component | organizations/header-information', function (h
files: [file],
},
);
await waitUntil(() => notificationService.sendErrorNotification.calledOnce);

// then
assert.true(organization.rollbackAttributes.calledOnce);
Expand Down Expand Up @@ -251,6 +254,7 @@ module('Integration | Component | organizations/header-information', function (h
files: [file],
},
);
await waitUntil(() => notificationService.sendErrorNotification.calledOnce);

// then
assert.true(organization.rollbackAttributes.calledOnce);
Expand Down
9 changes: 5 additions & 4 deletions ...ession-management/integration/infrastructure/repositories/jury-session-repository_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,10 +375,11 @@ describe('Integration | Repository | JurySession', function () {

// then
expect(pagination).to.deep.equal(expectedPagination);
expect(jurySessions[0].id).to.equal(expectedSCOSession.id);
expect(jurySessions[1].id).to.equal(expectedSUPSession.id);
expect(jurySessions[2].id).to.equal(expectedPROSession.id);
expect(jurySessions).to.have.lengthOf(3);
expect(jurySessions.map(({ id }) => id)).to.have.members([
expectedSCOSession.id,
expectedSUPSession.id,
expectedPROSession.id,
]);
});
});

Expand Down
Loading