Build fix: MSVC guard for Ninja/cl builds#1
Open
ShugokiFable wants to merge 1 commit into
Open
Conversation
…ions on MSVC variable instead of CMAKE_GENERATOR\n so Ninja + cl command-line builds also emit /Zi and /DEBUG (PDBs)
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the MSVC-specific configuration in Skyrim/CMakeLists.txt by replacing the generator check with a direct MSVC check and removing the /MP4 compiler option. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes (base a687721)
Build-only, one line: the MSVC compile options block now guards on
MSVCinstead ofCMAKE_GENERATOR MATCHES "Visual Studio", so Ninja + cl command-line builds also emit/Ziand/DEBUG(PDBs for crash logs).No source/runtime logic changes -- this mod already has thorough verification.
Compiled against alandtse CommonLibVR
ngsource build, MSVC.