Skip to content

test: adopt object-form igniteTest command steps - #93

Merged
0xjcf merged 17 commits into
betafrom
fas/object-form-ignitetest-command-steps
Jul 11, 2026
Merged

test: adopt object-form igniteTest command steps#93
0xjcf merged 17 commits into
betafrom
fas/object-form-ignitetest-command-steps

Conversation

@0xjcf

@0xjcf 0xjcf commented Jul 11, 2026

Copy link
Copy Markdown
Owner

Summary

  • replace positional igniteTest.when(name, input?) with object-form when({ name, input? }) during the v3 beta window
  • preserve discriminated command typing for required, optional, and no-input commands without changing runtime or story execute APIs
  • migrate the testing documentation and README examples to the current DSL

Verification

  • .fas/scripts/verify.sh --full
  • coderabbit review --agent -t committed --base beta -c AGENTS.md (0 findings)
  • push hook: 51 test files, 627 tests passed

Notes

  • no changeset or package version change; release metadata remains owned by the v3 release task
  • no migrations or deployment monitoring required

@coderabbitai

coderabbitai Bot commented Jul 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5b7af990-16f7-444f-a104-f61892ff6452

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fas/object-form-ignitetest-command-steps

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jul 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.23077% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.07%. Comparing base (2f86faa) to head (2e7aacc).
⚠️ Report is 19 commits behind head on beta.

Files with missing lines Patch % Lines
packages/ignite-element/src/tools/igniteTools.ts 86.36% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             beta      #93      +/-   ##
==========================================
- Coverage   91.25%   90.07%   -1.19%     
==========================================
  Files          33       38       +5     
  Lines        1830     3093    +1263     
  Branches      498      926     +428     
==========================================
+ Hits         1670     2786    +1116     
- Misses        150      285     +135     
- Partials       10       22      +12     
Flag Coverage Δ
unittests 90.07% <94.23%> (-1.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/ignite-element/src/runtime/agent.ts 91.48% <100.00%> (-3.46%) ⬇️
packages/ignite-element/src/testing.ts 74.34% <100.00%> (-0.10%) ⬇️
packages/ignite-element/src/tools/core.ts 96.00% <100.00%> (+2.48%) ⬆️
packages/ignite-element/src/xstate.ts 100.00% <ø> (ø)
packages/ignite-element/src/tools/igniteTools.ts 95.58% <86.36%> (-4.42%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@0xjcf
0xjcf merged commit cab2357 into beta Jul 11, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant