chore: add self-hosted Renovate dependency updates - #91
Conversation
WalkthroughAdds a Renovate GitHub Actions workflow (manual/weekly trigger) and a renovate.json configuration controlling scheduling, grouping, and update scope. Documents the policy in CONTRIBUTING.md and updates related task tracker files reflecting status changes. ChangesRenovate Dependency Automation
Estimated code review effort: 2 (Simple) | ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## beta #91 +/- ##
==========================================
- Coverage 91.25% 91.02% -0.24%
==========================================
Files 33 34 +1
Lines 1830 1972 +142
Branches 498 540 +42
==========================================
+ Hits 1670 1795 +125
- Misses 150 167 +17
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
@CodeRabbit review |
✅ Action performedReview finished.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (3)
renovate.json (1)
11-11: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win
enabledManagers: ["npm"]excludes thegithub-actionsmanager, so the pinned action version inrenovate.ymlwon't be auto-updated.Since the workflow pins
renovatebot/github-action@v46.1.18and (per the earlier comment) ideally also pinsrenovate-version, consider adding"github-actions"toenabledManagersso Renovate keeps its own action/version pins current, rather than requiring manual bumps.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@renovate.json` at line 11, The Renovate configuration only enables the npm manager, so it will not update pinned GitHub Actions references used by the project itself. Update the Renovate config to include the github-actions manager alongside npm, and ensure the existing Renovate workflow pinning in the renovate.yml setup (for the renovatebot/github-action and renovate-version references) is covered so those versions stay auto-updated..github/workflows/renovate.yml (2)
27-27: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueConsider using
github.repositoryinstead of hardcoding the repo slug.
RENOVATE_REPOSITORIES: 0xjcf/ignite-elementduplicates information already known to the workflow context and will silently point at the wrong repo if the repo is ever renamed/forked.♻️ Proposed change
- RENOVATE_REPOSITORIES: 0xjcf/ignite-element + RENOVATE_REPOSITORIES: ${{ github.repository }}🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/renovate.yml at line 27, The Renovate workflow is hardcoding the repository slug in RENOVATE_REPOSITORIES, which duplicates workflow context and can break on rename or fork. Update the renovate job configuration to derive the repo from github.repository instead of a fixed owner/repo value, and keep the change localized to the renovate environment setup in the workflow.
20-29: 🩺 Stability & Availability | 🔵 Trivial | ⚡ Quick winPin
renovate-versionto a full semver or checksum. Leaving it unset uses the action’s default Renovate image tag, so the runtime can drift between runs and break reproducibility.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/renovate.yml around lines 20 - 29, The Renovate GitHub Action setup is not pinned to a specific Renovate runtime, so it can drift between runs. Update the existing `Run self-hosted Renovate` job in `renovatebot/github-action@v46.1.18` to set the `renovate-version` input explicitly to a full semver or checksum, keeping the current `with` block and `RENOVATE_*` env settings intact.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In @.github/workflows/renovate.yml:
- Line 27: The Renovate workflow is hardcoding the repository slug in
RENOVATE_REPOSITORIES, which duplicates workflow context and can break on rename
or fork. Update the renovate job configuration to derive the repo from
github.repository instead of a fixed owner/repo value, and keep the change
localized to the renovate environment setup in the workflow.
- Around line 20-29: The Renovate GitHub Action setup is not pinned to a
specific Renovate runtime, so it can drift between runs. Update the existing
`Run self-hosted Renovate` job in `renovatebot/github-action@v46.1.18` to set
the `renovate-version` input explicitly to a full semver or checksum, keeping
the current `with` block and `RENOVATE_*` env settings intact.
In `@renovate.json`:
- Line 11: The Renovate configuration only enables the npm manager, so it will
not update pinned GitHub Actions references used by the project itself. Update
the Renovate config to include the github-actions manager alongside npm, and
ensure the existing Renovate workflow pinning in the renovate.yml setup (for the
renovatebot/github-action and renovate-version references) is covered so those
versions stay auto-updated.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: fb5c5fc5-404c-4f97-9167-dcb016fec5cd
📒 Files selected for processing (5)
.fas/TASKS.md.fas/tasks/add-renovate-for-ongoing-dependency-currency-so-state-lib-ve.md.github/workflows/renovate.ymlCONTRIBUTING.mdrenovate.json
1 participant
Summary
Verification
Summary by CodeRabbit
New Features
Documentation
Chores