Skip to content

fix(actor-web): collapse address contract to string - #84

Merged
0xjcf merged 8 commits into
betafrom
fas/actorweb-address-collapse
Jul 5, 2026
Merged

fix(actor-web): collapse address contract to string#84
0xjcf merged 8 commits into
betafrom
fas/actorweb-address-collapse

Conversation

@0xjcf

@0xjcf 0xjcf commented Jul 5, 2026

Copy link
Copy Markdown
Owner

Summary

  • Collapse ActorWebAddress from the transitional string | legacy object union to plain string.
  • Bump @actor-web/runtime dev/peer dependency floor to 0.2.x / >=0.2.0.
  • Update actor-web test fixtures and the canonical compat type guard to reject legacy object addresses.
  • Add a breaking changeset for @ignite-element/adapters and ignite-element.

Verification

  • Red receipt: pnpm --filter @ignite-element/adapters typecheck failed before implementation with Unused '@ts-expect-error' directive.
  • pnpm --filter @ignite-element/adapters typecheck
  • pnpm --filter ignite-element typecheck
  • fas validate-task
  • .fas/scripts/verify.sh --full
  • coderabbit review --agent -t committed --base beta -c AGENTS.md raised 1 issue; fixed changeset severity.
  • Rerun coderabbit review --agent -t committed --base beta -c AGENTS.md: 0 issues.
  • Push hook: package tests passed, 45 files / 463 tests.

Notes

  • Single-task epic closeout used direct fas done; no fas batch close.
  • The original runtime queue row task-1782269396312 remains deferred on beta until this PR merges, then should be completed during babysit/post-merge.

@coderabbitai

coderabbitai Bot commented Jul 5, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1baf2e39-2310-4e5b-991b-fd893c9246be

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fas/actorweb-address-collapse

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jul 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.27%. Comparing base (9e12bdd) to head (bf9dce3).
⚠️ Report is 1 commits behind head on beta.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             beta      #84   +/-   ##
=======================================
  Coverage   90.27%   90.27%           
=======================================
  Files          32       32           
  Lines        1573     1573           
  Branches      447      447           
=======================================
  Hits         1420     1420           
  Misses        143      143           
  Partials       10       10           
Flag Coverage Δ
unittests 90.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@0xjcf
0xjcf merged commit e0f0255 into beta Jul 5, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant