Skip to content

fix: close ignite ecosystem bridge follow-ups - #83

Merged
0xjcf merged 12 commits into
betafrom
fas/ignite-ecosystem-followups
Jul 3, 2026
Merged

fix: close ignite ecosystem bridge follow-ups#83
0xjcf merged 12 commits into
betafrom
fas/ignite-ecosystem-followups

Conversation

@0xjcf

@0xjcf 0xjcf commented Jul 3, 2026

Copy link
Copy Markdown
Owner

Summary

  • split the headless runtime host type to use EventTarget without HTMLElement casting
  • tighten igniteTools scalar provider envelopes and clarify canExecute manifest refresh wording
  • update ActorWebAdapter command-source warnings to refer to command-capable sources
  • defer ActorWebAddress collapse until @actor-web/runtime publishes the branded string address and this repo bumps the dependency

Verification

  • pnpm --filter ignite-element exec vitest --run src/tests/tools.scalar.test.ts src/tests/tools.anthropic.test.ts src/tests/tools.test.ts
  • pnpm --filter ignite-element exec vitest --run src/tests/adapters/ActorWebAdapter.test.ts
  • pnpm --filter @ignite-element/adapters typecheck
  • fas validate-task per completed task
  • .fas/scripts/verify.sh --full
  • coderabbit review --agent -t committed --base beta -c AGENTS.md: 0 issues

@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e56eedeb-928b-47ba-b09f-1aeb56c0c6a2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fas/ignite-ecosystem-followups

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jul 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.27%. Comparing base (15aa09e) to head (9e12bdd).
⚠️ Report is 1 commits behind head on beta.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             beta      #83      +/-   ##
==========================================
+ Coverage   90.26%   90.27%   +0.01%     
==========================================
  Files          32       32              
  Lines        1571     1573       +2     
  Branches      444      447       +3     
==========================================
+ Hits         1418     1420       +2     
  Misses        143      143              
  Partials       10       10              
Flag Coverage Δ
unittests 90.27% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ackages/ignite-element/src/IgniteElementFactory.ts 97.20% <100.00%> (ø)
...kages/ignite-element/src/createComponentFactory.ts 91.66% <100.00%> (+0.36%) ⬆️
...ages/ignite-element/src/createProjectionFactory.ts 96.15% <ø> (ø)
packages/ignite-element/src/runtime/agent.ts 95.65% <ø> (ø)
packages/ignite-element/src/tools/igniteTools.ts 100.00% <ø> (ø)
packages/ignite-element/src/tools/scalar.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@0xjcf
0xjcf merged commit 4aef262 into beta Jul 3, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant