Skip to content

Fix smart-home scalar value legibility - #79

Merged
0xjcf merged 3 commits into
betafrom
fas/smart-home-scalar-value-legibility
Jun 30, 2026
Merged

Fix smart-home scalar value legibility#79
0xjcf merged 3 commits into
betafrom
fas/smart-home-scalar-value-legibility

Conversation

@0xjcf

@0xjcf 0xjcf commented Jun 30, 2026

Copy link
Copy Markdown
Owner

Summary

  • Add semantic descriptions to smart-home scalar enum inputs while preserving the Option D { value } envelope.
  • Cover the Anthropic schema output for door and scene scalar commands.
  • Mark GAPS Version Packages #5 fixed and record the FAS task scope.

Verification

  • pnpm --filter ignite-element exec vitest --run --root ../../examples/agents/smart-home --config ../../examples/agents/smart-home/vite.config.ts
  • npm run test:examples -- --covers-package examples/agents/smart-home
  • fas validate-task
  • .fas/scripts/verify.sh --full
  • coderabbit review --agent -t committed --base beta -c AGENTS.md (findings: 0)

@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5c8b1543-b886-4b78-9e81-1a820b4fdfd8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fas/smart-home-scalar-value-legibility

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.26%. Comparing base (f6a7a75) to head (146f92b).
⚠️ Report is 4 commits behind head on beta.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             beta      #79      +/-   ##
==========================================
+ Coverage   90.12%   90.26%   +0.13%     
==========================================
  Files          32       32              
  Lines        1540     1571      +31     
  Branches      436      446      +10     
==========================================
+ Hits         1388     1418      +30     
- Misses        142      143       +1     
  Partials       10       10              
Flag Coverage Δ
unittests 90.26% <ø> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@0xjcf
0xjcf merged commit 39c2dd1 into beta Jun 30, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant